Feature/designators component #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XanderVertegaal
approved these changes
Aug 6, 2024
| <button class="btn btn-primary" type="submit" | ||
| [disabled]="disabled" | ||
| (blur)="blur$.next()"> | ||
| <lc-icon [icon]="actionIcons.add" aria-label="add" /> |
There was a problem hiding this comment.
Suggested change
| <lc-icon [icon]="actionIcons.add" aria-label="add" /> | |
| <lc-icon [icon]="actionIcons.add" aria-label="add designator" /> |
(I'm not sure how specific these aria-labels are expected to be.)
| } | ||
|
|
||
| registerOnChange(fn: (_: any) => void): void { | ||
| this.designators$.subscribe(fn); |
There was a problem hiding this comment.
These subscriptions are not closed at the moment. For bonus points, please make sure they are canceled upon component destruction.
Comment on lines
+59
to
+65
| onAddFormSubmit() { | ||
| if (this.addForm.valid) { | ||
| const designator = this.addForm.controls.designator.value; | ||
| this.designators$.next(this.designators$.value.concat([designator])); | ||
| this.addForm.reset({ designator: '' }); | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| onAddFormSubmit() { | |
| if (this.addForm.valid) { | |
| const designator = this.addForm.controls.designator.value; | |
| this.designators$.next(this.designators$.value.concat([designator])); | |
| this.addForm.reset({ designator: '' }); | |
| } | |
| } | |
| onAddFormSubmit(): void { | |
| if (this.addForm.invalid) { | |
| return; | |
| } | |
| const designator = this.addForm.controls.designator.value; | |
| this.designators$.next(this.designators$.value.concat([designator])); | |
| this.addForm.reset({ designator: '' }); | |
| } |
| } | ||
|
|
||
| removeDesignator(index: number) { | ||
| const spliced = _.clone(this.designators$.value) |
There was a problem hiding this comment.
Is deep cloning necessary here? The control seems to continue working if I remove it.
| this.designators$.subscribe(fn); | ||
| } | ||
|
|
||
| registerOnTouched(fn: (_: any) => void): void { |
There was a problem hiding this comment.
Instead of using any here, you can use unknown, which does not give a type warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
DesignatorsControlComponent, which contains the form widget for the designators of people, places, and things.Screenshot:
