Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments to fetch API #27

Merged
merged 5 commits into from
Jan 31, 2024
Merged

Adjustments to fetch API #27

merged 5 commits into from
Jan 31, 2024

Conversation

tijmenbaarda
Copy link
Contributor

Adjust fetch API to support some requirements for the EDPOP VRE:

  • Start fetching from an offset instead of from the beginning (this is needed because Reader objects won't be shared across API requests from the frontend, since every request might run in a different process)
  • Adjust the maximum number of new results to fetch each time (this is needed to allow the user to control how many records they want to see)
  • Merge the fetch() and fetch_next() methods

@jgonggrijp
Copy link

Quick comment: this seems like a solution for one of your open ends in CentreForDigitalHumanities/EDPOP#148. Next time you report a problem in one repository and work on a solution in another, please add a cross-reference at either end (like I'm doing here) so that it will be visible for future readers (like me) that you are already working on a solution.

@tijmenbaarda
Copy link
Contributor Author

Quick comment: this seems like a solution for one of your open ends in UUDigitalHumanitieslab/EDPOP#148. Next time you report a problem in one repository and work on a solution in another, please add a cross-reference at either end (like I'm doing here) so that it will be visible for future readers (like me) that you are already working on a solution.

Sure, will do next time!!

@tijmenbaarda tijmenbaarda merged commit 48c6206 into develop Jan 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants