Partial fix for the innocent_witches branch #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mon obfuscation tactics.
…ow we use those to recognize them as well
…de so now use the presence of a linenumber attribute on it to detect if it was unconditional
Innocent witches
… prevent rpyc modification shenanigans.
|
heya, figured I'd reply to this after like 3 years 😓 I think the years of changes have made this pull request a bit hard to read, and the branch has diverged quite a bit as well. I'm also not sure how many fixes here have mirrored ones in the repo already right now. I think we'll have to separate the merged in commits from the ones that actually handle the game specific things to make sense of this and move that branch forward, so I don't really see a chance of this pull landing in this format. That said, I'll keep it open for whoever needs this right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves #122
I managed to solve the
FakeUnpicklingError: <class 'store.LanguageCases'> was instantiated with unexpected arguments (u'Hermione',), {}error I got when unrpycing Innocent Witches 0.6.5f.I did kinda like the ELSE_COND fix, but my fix can probably be simplified.
Next step is solving the
Unknown AST node: <class 'store.ATL.RawUse'>for RawIf, RawUse, RawChoice, RawRepeat, RawAnimation, RawBlock and (surprisingly) renpy.ast.PostUserStatement.That last one may come from renpy updates and as such, may deserve an update in master.