Support MemoLanes archive export (Part 1) #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaviarChen
requested changes
May 12, 2024
server/src/misc_handler.rs
Outdated
| @@ -145,5 +196,5 @@ async fn upload<'r>( | |||
| } | |||
|
|
|||
| pub fn routes() -> Vec<rocket::Route> { | |||
| routes![upload, download] | |||
| routes![upload, download,export_all] | |||
There was a problem hiding this comment.
这个项目没有强制格式检查。 最好还是手动跑一下 cargo fmt --all
| icon={<FileDownloadIcon />} | ||
| onClick={() => { | ||
| console.log("导出Achive Zip."); | ||
| window.open(Api.backendUrl + "misc/export_all", "_blank"); |
There was a problem hiding this comment.
hmm 这种写法应该只能在 Single User Mode 下运行，因为这样无法传token。
这也是为什么另外那个下载的函数是先通过一个请求获得一次性下载链接，再用这个下载链接下载。
There was a problem hiding this comment.
一个让单用户模式行为更符合普通模式的办法：前端启动时检测是否是单用户模式，是的话设置一个特殊token。服务端收到特殊token后，检测是否是单用户模式，再通过验证。 其实可以放到一个单独PR中，不过我也没有特别在意。
server/src/misc_handler.rs
Outdated
| .all(db) | ||
| .await?; | ||
|
|
||
| let temp_dir = TempDir::new().unwrap(); |
There was a problem hiding this comment.
不要 unwrap 直接丢 exception，这里用 ? 向上级传错误更合适一些
CaviarChen
requested changes
Oct 21, 2024
server/src/misc_handler.rs
Outdated
Comment on lines
134
to
148
| let zip_file_path = temp_dir.path().join("temp_sync.zip"); | ||
| let mut zip_file = fs::File::create(&zip_file_path)?; | ||
| let mut zip = zip::ZipWriter::new(&mut zip_file); | ||
| let options = zip::write::SimpleFileOptions::default() | ||
| .compression_method(zip::CompressionMethod::Stored); | ||
| zip.add_directory("Sync/", options)?; | ||
|
|
||
| let entity::snapshot::SyncFiles(sync_files) = snapshot.sync_files; | ||
| for (file_id, sha256) in &sync_files { | ||
| let sync_file = data_fetcher::SyncFile::create_from_id(*file_id, sha256)?; | ||
| zip.start_file(format!("Sync/{}", sync_file.filename()), options)?; | ||
| let mut file = server_state.file_storage.open_file(&user, sha256)?; | ||
| std::io::copy(&mut file, &mut zip)?; | ||
| } | ||
| zip.finish()?; |
There was a problem hiding this comment.
这段代码基本上与上方download_snapshot 中的那段一致，应该提取出一个函数复用代码。
CaviarChen
approved these changes
Nov 4, 2024
CaviarChen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.