Make the C runtime thread-safe #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by specifying the the heap should be allocated for each thread. → `catala_init` should still be called just once → `catala_free_all` will actually only free the memory of the current thread (IIUC it will be reclaimed automatically upon death anyway)
vincent-botbol
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by specifying the the heap should be allocated for each thread.
→
catala_initshould still be called just once→
catala_free_allwill actually only free the memory of the currentthread (IIUC it will be reclaimed automatically upon death anyway)
Note: this is a test and hasn't been tested whatsoever