Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Stop using String token in pygments lexers" #773

Closed
wants to merge 1 commit into from

Conversation

denismerigoux
Copy link
Contributor

Reverts #772 : the fix completely breaks at least the generation of the Catala syntax sheet cheat (see attached) :

Capture d’écran du 2025-01-15 15-19-21

@denismerigoux denismerigoux added ❌ bug Something isn't working 🏗️ build system Build system or Makefile labels Jan 15, 2025
@denismerigoux denismerigoux requested a review from AltGr January 15, 2025 14:21
@denismerigoux
Copy link
Contributor Author

@pierregoutagny I'm sorry your fix was not the right solution it seems...

@denismerigoux
Copy link
Contributor Author

Instead, the syntax sheet cheat was correctly generated before the #772 PR was merged (https://github.com/CatalaLang/catala/actions/runs/12745997886) :

Capture d’écran du 2025-01-15 15-24-57

@pierregoutagny
Copy link
Contributor

Oh sorry for this break. I have trouble compiling the syntax.pdf file locally (it looks like your screenshot no matter the version), but my guess would be that if you do the same as for the unit test it could work. For instance, could you check if the pdf works when you remove the \PYG on lines 201 and 202 of syntax_en.tex ? That is replacing

\newcommand*\FancyVerbStartString{\PYG{l+s}{```catala}}
\newcommand*\FancyVerbStopString{\PYG{l+s}{```}}

by

\newcommand*\FancyVerbStartString{```catala}
\newcommand*\FancyVerbStopString{```}

@denismerigoux
Copy link
Contributor Author

Oh yes replacing \PYG{l+s}{```catala}} by {```catala} is probably a good fix. Can you put it in another PR? I'll merge this new one and hope it fixes the cheat sheet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❌ bug Something isn't working 🏗️ build system Build system or Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants