Fix confusing disambiguation errors appearing instead of type errors #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a non-delayed error happens after delayed errors, these should take precedence and be raised rather than ignored. Indeed, it's often a consequence of delayed errors. This happened in the disambiguation phase where a type inconsistency would be skipped, leading to a failure to disambiguate, and only the latter was printed resulting in a puzzling error.
denismerigoux
approved these changes
Jan 8, 2025
Comment on lines
+534
to
+552
| let result = | ||
| match f () with | ||
| | r -> fun () -> r | ||
| | exception (CompilerError _ as e) -> | ||
| let bt = Printexc.get_raw_backtrace () in | ||
| fun () -> Printexc.raise_with_backtrace e bt | ||
| | exception e -> raise e | ||
| in | ||
| match global_errors.errors with | ||
| | None -> error ~internal:true "intertwined delayed error scope" | ||
| | Some [] -> | ||
| global_errors.errors <- None; | ||
| result () | ||
| | Some [err] -> | ||
| global_errors.errors <- None; | ||
| raise (CompilerError err) | ||
| | Some errs -> | ||
| global_errors.errors <- None; | ||
| raise e | ||
| raise (CompilerErrors (List.rev errs)) |
There was a problem hiding this comment.
This could use a little comment to understand what's going on :)
vincent-botbol
approved these changes
Jan 8, 2025
|
@vincent-botbol haha don't worry you certainly have as much on my account ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #749 ;
the PR also has a patch that greatly improves real disambiguation errors when they happen.
The issue was actually with the way we attempt to gather multiple typing errors: this can get us in an inconsistent state after the first error, and any non-delayed exception raised at that point (including
internal inconsistencycompiler errors) would break out... and hide all delayed exceptions.This is visible in test
array/bad/type_error_in_filter.catala_enwhich would raise aCannot resolve typingerror because assumptions of the typer are no longer guaranteed.The behaviour implemented here is to print the errors that have been delayed, and actually hide the non-delayed error instead (it seems safer to assume, in general, that it is a consequence of an inconsistent state, rather than the opposite. We could put it back when in debug mode if we ever find cases where it would have been useful).