Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add right margin to confirm buttons #129

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Irian
Copy link

@Irian Irian commented Nov 14, 2024

No description provided.

@CarlosNZ
Copy link
Owner

Hi, this doesn't seem particularly necessary. Do you have a reason why you think it should be in?

Can't you just add the CSS to your own implementation if you want it?

@Irian
Copy link
Author

Irian commented Nov 22, 2024

Dear Carlos,

You're right in that this is not strictly necessary, it is more of a visual issue as the cancel icon and type dropdown are too close together compared to the other icons. Of course I can add this CSS to my implementation, but I thought it would be a nice to have for all.

Kind regards

@CarlosNZ
Copy link
Owner

Thanks @Irian.
There's actually a little bit of whitespace around the "cancel" icon, which means I'd always thought there was enough padding between it and the selector.

Screenshot 2024-11-23 at 11 12 03 AM

And it means with your suggested additional margin it looks a little too much:

Screenshot 2024-11-23 at 11 11 31 AM

Just eyeballing it, looks like about 0.2 em would even it out. But that would change if you use a different cancel icon too. Just wondering if it looks different for you?

I think I'd rather actually fix the icons so the Confirm and Cancel icons have identical natural padding/scaling and then your adjustment would probably be required! Feel free to do that if you can be bothered ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants