Tweak endpoint response format.

Carifio24 · Oct 18, 2023 · f5e0a38 · f5e0a38
1 parent c7e5dec
commit f5e0a38
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/src/database.ts b/src/database.ts
@@ -665,10 +665,10 @@ export async function getQuestionsForStory(storyName: string, newestOnly=true):
 }
 
 
-export async function getDashboardGroupClasses(code: string): Promise<number[]> {
+export async function getDashboardGroupClasses(code: string): Promise<number[] | null> {
   const group = await DashboardClassGroup.findOne({ where: { code } });
   if (group === null) {
-    return [];
+    return null;
   }
   const classIDs = group.class_ids;
   return isNumberArray(classIDs) ? classIDs : [];

diff --git a/src/server.ts b/src/server.ts
@@ -656,8 +656,14 @@ app.put("/options/:studentID", async (req, res) => {
 
 app.get("/dashboard-group-classes/:code", async (req, res) => {
   const classIDs = await getDashboardGroupClasses(req.params.code);
-  res.statusCode = classIDs.length > 0 ? 200 : 404;
-  res.json({
-    class_ids: classIDs
-  });
+  if (classIDs === null) {
+    res.statusCode = 404;
+    res.json({
+      error: `Could not find a dashboard group for code ${req.params.code}`
+    });
+  } else {
+    res.json({
+      class_ids: classIDs
+    });
+  }
 });