A0-3858: Benchmark on-chain verifier (1/2) #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deuszx
reviewed
Jan 25, 2024
deuszx
reviewed
Jan 25, 2024
DamianStraszak
approved these changes
Jan 29, 2024
fbielejec
reviewed
Jan 30, 2024
fbielejec
reviewed
Jan 30, 2024
fbielejec
reviewed
Jan 30, 2024
fbielejec
reviewed
Jan 30, 2024
fbielejec
reviewed
Jan 30, 2024
fbielejec
approved these changes
Jan 30, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 5, 2024
# Description Follow-up to #1583: 1. Make `BenchCircuit` non-generic: it posed ridiculous problems when trying to run proof generation for a matrix of parameters. 2. Run trusted setup for `k = 20` (it took ~2h on `12th Gen Intel® Core™ i7-12800H × 20` with `16GB` RAM) 3. Run actual benchmarks for a cartesian product of parameters: - number of instances from `[1, 2, 8, 16, 64, 128]` - gate blowup from `[1, 8, 64, 512, 4096]` (maximum number of rows was `128 · 4096 ~= 0.5M` To avoid awful boilerplate with 30 repeated functions in the benchmark suite, I wrote a semi-awful macro. I added all the artifacts to VCS, but unfortunately I forgot to save SRS... 🙈 in case we need to rerun benches, we have to remember about it 😛 ## Type of change Please delete options that are not relevant. - New feature (non-breaking change which adds functionality) # Checklist: - I have made neccessary updates to the Infrastructure - I have made corresponding changes to the existing documentation - I have created new documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We run benchmarks for the on-chain verifier.
Even though the actual verification happens in the
aleph-runtime-interfacescrate, we have to put them in the chain extension library for two reasons:For now, we use only a single circuit. The follow-up PR will extend measurements for other layouts.
There was also a very nasty bug introduced in #1405 which turned off custom host functions from the benchmarking node. It has been fixed in this PR.
For the people who can read halo2 diagrams, a diagram of a circuit <5,3>:
Type of change
Checklist: