Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A0-4563: Added unit test for censorship resistance in Extender #503

Merged
merged 7 commits into from
Dec 9, 2024

Conversation

Marcin-Radecki
Copy link
Contributor

@Marcin-Radecki Marcin-Radecki commented Dec 5, 2024

Introduced 2 UTs, similar to existing ones, but with prepared DAG that contains non-direct parents. It turns out that current testing code almost support non-direct parents, as ReconstructedUnit control hash is created based on the parents injected by the test, except one method random_unit_with_parents that assumed each parent round is the same.

Currently, those tests are disabled since they (expectedly) panic at

units are added in order
thread 'extension::extender::test::given_minimal_dag_with_orphaned_node_when_producing_batches_have_correct_length' panicked at consensus/src/extension/election.rs:56:42:

This PR should not contain any changes to the production code.

Copy link

github-actions bot commented Dec 5, 2024

Please make sure the following happened

  • Appropriate tests created
  • Infrastructure updated accordingly
  • Updated existing documentation
  • New documentation created
  • Version bumped if breaking changes

Copy link
Contributor

@timorleph timorleph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strict TDD in ABFT, I've never thought I would see the day... <3 (;_;) <3

@Marcin-Radecki Marcin-Radecki added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit be8af3d Dec 9, 2024
11 checks passed
@Marcin-Radecki Marcin-Radecki deleted the A0-4563 branch December 9, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants