fix: #290 supports oneOf polymorphic types with dart_mappable #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-burton
commented
Jan 20, 2025
| final class UniversalComponentClass extends UniversalDataClass { | ||
| /// Constructor for [UniversalComponentClass] | ||
| const UniversalComponentClass({ | ||
| UniversalComponentClass({ |
There was a problem hiding this comment.
I had to remove the const constuctor as the discriminatorValue field needs to be updated after the initial UniversalComponentClass class is constructed.
josh-burton
commented
Jan 20, 2025
| // The name of the property that is used to discriminate the oneOf variants | ||
| String propertyValue, | ||
| String parentClass, | ||
| })? discriminatorValue; |
There was a problem hiding this comment.
This discriminatorValue field could potentially be combined with discriminator above, perhaps adding an extra field to denote whether this class is a discrinator parent or discriminated value class.
josh-burton
commented
Jan 20, 2025
| @@ -198,6 +198,19 @@ void main() { | |||
| ); | |||
| }); | |||
|
|
|||
| test('discriminated_one_of.3.0_mappable', () async { | |||
There was a problem hiding this comment.
It would be nice to combine this test with the discriminated_one_of.3.0 test above.
I've opened #291 to suggest some changes to the test structure to allow this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for oneOf polymorphic (discriminated) types with dart_mappable.
Most of the changes are within the dart mappable dto template, but a few parser changes were required.
I've made some comments on various lines which are areas of discussion.