Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDGE-766] Prevent issue alert UUID being outputted #45

Closed
wants to merge 1 commit into from

Conversation

Qantas94Heavy
Copy link

Context

Basically same as Canva/go-sentry#8 but implementing this in the TF provider instead.

uuid field is causing permanent TF drift, failures to apply and is not required in the alert output.

Example: https://buildkite.com/canva-org/infra-apply-terraform/builds/170168

  # module.sentry_high_frequency_alert[0].sentry_issue_alert.default will be updated in-place
  ~ resource "sentry_issue_alert" "default" {
      ~ actions      = jsonencode(
          ~ [
              ~ {
                  ~ channel    = "edge-notifications" -> "#edge-notifications"
                    id         = "sentry.integrations.slack.notify_action.SlackNotifyServiceAction"
                  ~ name       = "Send a notification to the Canva Slack workspace to edge-notifications (optionally, an ID: C021PEQFXGV) and show tags [] and notes  in notification" -> "Send a notification to the Canva Slack workspace to #edge-notifications (optionally, an ID: C021PEQFXGV) and show tags [] and notes  in notification"
                    tags       = ""
                  - uuid       = "7e1fecf2-bd58-4a8b-990c-c28a61bba5e9" -> null
                    # (3 unchanged elements hidden)
                },
            ]
        )
        id           = "14511763"
        name         = "High frequency of events(+500) in prod)"
        # (7 unchanged attributes hidden)
    }

Failure to apply:

│ Error: Provider produced inconsistent result after apply
│
│ When applying changes to
│ module.sentry_high_frequency_alert[0].sentry_issue_alert.default, provider
│ "provider[\"canva.com/infrastructure/sentry\"]" produced an unexpected new
│ value: .actions: was
│ cty.StringVal("[{\"channel\":\"#edge-notifications\",\"channel_id\":\"C021PEQFXGV\",\"id\":\"sentry.integrations.slack.notify_action.SlackNotifyServiceAction\",\"label\":\"Send
│ a slack notification\",\"name\":\"Send a notification to the Canva Slack
│ workspace to #edge-notifications (optionally, an ID: C021PEQFXGV) and show
│ tags [] and notes  in
│ notification\",\"tags\":\"\",\"workspace\":\"23762\"}]"), but now
│ cty.StringVal("[{\"channel\":\"edge-notifications\",\"channel_id\":\"C021PEQFXGV\",\"id\":\"sentry.integrations.slack.notify_action.SlackNotifyServiceAction\",\"label\":\"Send
│ a slack notification\",\"name\":\"Send a notification to the Canva Slack
│ workspace to edge-notifications (optionally, an ID: C021PEQFXGV) and show
│ tags [] and notes  in
│ notification\",\"tags\":\"\",\"uuid\":\"7e1fecf2-bd58-4a8b-990c-c28a61bba5e9\",\"workspace\":\"23762\"}]").
│
│ This is a bug in the provider, which should be reported in the provider's
│ own issue tracker.

Intent

Remove the UUID field from Sentry issue alerts.

@Qantas94Heavy Qantas94Heavy changed the title Prevent issue alert UUID being outputted [EDGE-766] Prevent issue alert UUID being outputted Jun 28, 2024
@boh-dan
Copy link

boh-dan commented Jul 2, 2024

@Qantas94Heavy thank you for help but this issue we can solve without changes to the Sentry TF PRovider. You can follow the fix in this PR - https://github.com/Canva/infrastructure/pull/95765

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants