Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proposed temporary RavenPy logos #428

Merged
merged 11 commits into from
Jan 14, 2025
Merged

Add proposed temporary RavenPy logos #428

merged 11 commits into from
Jan 14, 2025

Conversation

Zeitsperre
Copy link
Member

@Zeitsperre Zeitsperre commented Dec 13, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • This is a PR to work on and discuss the potential RavenPy Logo

Does this PR introduce a breaking change?

No.

Other information:

When merging the final version of this PR, we should use "Squash and Merge" in order to not save lots of images in our git history.

The temporary logos were made by grouping colours via a filter and doing some light touch-ups in GIMP, then extracting the bitmap and rescaling the SVG using Inkscape. There's probably a better way to keep some shading, but this seemed easy and reduces the size of the images to something more reasonable.

Ideally, we would want a small (150x150) and large (300x300) version of the logo that we land on in PNG format.

@coveralls
Copy link

coveralls commented Dec 13, 2024

Coverage Status

coverage: 81.283% (+0.004%) from 81.279%
when pulling 712e90d on logos
into 4e0db36 on master.

@Zeitsperre Zeitsperre changed the title [DO NOT MERG] Add proposed temporary RavenPy logos [DO NOT MERGE] Add proposed temporary RavenPy logos Dec 14, 2024
@lou-a
Copy link
Collaborator

lou-a commented Dec 16, 2024

I think it would look better if the right-hand side of the sky is more orange than yellow, and if the waves in the middle are a single colour. Happy to make these changes if that's easier - let me know what the best way is for me to do that.

@Zeitsperre
Copy link
Member Author

@lou-a Please feel free to make those changes, I really appreciate it!

For the colours, this might be a good reference:
image

I can take care of the placement and integration of the logos once they're finalized.

@lou-a
Copy link
Collaborator

lou-a commented Jan 7, 2025

I just added a new version of the logo. What do you think @Zeitsperre and @huard ?

@Zeitsperre
Copy link
Member Author

I just added a new version of the logo. What do you think @Zeitsperre and @huard ?

Much cleaner! This is great for a first version. Ideally, I'd like to find a way to generate this using splines so that lines end properly or flow into each other seamlessly, but given the budget, I think we have something we can work with.

@Zeitsperre
Copy link
Member Author

The docs aren't building due to issues with the library in general (fixed in #434) but here's what I have rendered locally:

image

…deautolink, fix imports

Signed-off-by: Trevor James Smith <[email protected]>
@github-actions github-actions bot added the docs label Jan 7, 2025
Signed-off-by: Trevor James Smith <[email protected]>
@Zeitsperre
Copy link
Member Author

One thing I want to mention before we merge this is that because this project is MIT Licensed, technically that extends to the logos as well. If people want to take them and use them for something else (i.e. removing the "RavenPy"), that would probably be permitted.

If we explicitly don't want that, we can either:

  1. Change the license of the repository to something that covers logo uses.
  2. Apply for trademark protections (absolutely not happening).

Personally, I don't care, but I figured it would be worth mentioning.

@lou-a
Copy link
Collaborator

lou-a commented Jan 8, 2025

That's fine by me as well @Zeitsperre.

@huard
Copy link
Collaborator

huard commented Jan 8, 2025

Please make sur this PR is squashed, not merged, so we're not pulling draft logo files in the history.

@Zeitsperre
Copy link
Member Author

@huard I'll let you be the one to approve this. I think we have something that does the job for now.

I'll merge the other docs changes PR once this is merged to the main branch.

@Zeitsperre Zeitsperre marked this pull request as ready for review January 8, 2025 21:36
Signed-off-by: Trevor James Smith <[email protected]>
Signed-off-by: Trevor James Smith <[email protected]>
@github-actions github-actions bot added the CI label Jan 14, 2025
@Zeitsperre Zeitsperre merged commit ac33bed into master Jan 14, 2025
14 checks passed
@Zeitsperre Zeitsperre deleted the logos branch January 14, 2025 18:44
@Zeitsperre Zeitsperre changed the title [DO NOT MERGE] Add proposed temporary RavenPy logos Add proposed temporary RavenPy logos Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants