Remove Entities from outer layers using DTOs #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all references to Entities from the Controllers, instead replacing them with a simple Data Transfer Object representation.
A significant change for the UI implementation would be the requirement that the Controllers "select" which item that they will work on before every action, rather than being able to simply pass in an object of its choosing. I'm tired right now so I may take another look at this system in the future.
Due to the reliance on mutation for our previous implementation of the Controllers, many changes had to be made to ensure that the same objects internally were being mutated as the copy specified from the Controller. I have done a bit of testing on the CLI demo, and it seems to work as before, at least for the parts which are functional in the CLI.
Note that the database has yet to be modified to fit the changes in the PR.
Closes #31.