Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature 7 - Tests and README #84

Merged
merged 20 commits into from
Dec 9, 2022
Merged

Feature 7 - Tests and README #84

merged 20 commits into from
Dec 9, 2022

Conversation

jltng
Copy link
Contributor

@jltng jltng commented Dec 6, 2022 •
edited
Loading

SO MUCH DEBUGGING DONE!!!!! hopefully last code push massive thank you to tiare

Course enrolment interactor:

  • TaskMap and FileTaskMap not synced between
  • looking for the wrong task ids for instructor tasks
  • Maps being overriden for no reason
  • creating copies of Task objects
  • main UIRSerialization issue finally resolved --> have to delete the data files before each push

To-do:

  • README + screenshots

@jltng jltng linked an issue Dec 6, 2022 that may be closed by this pull request
README Description #62
Closed
@jltng jltng self-assigned this Dec 6, 2022
@jltng jltng added the tests Testing label Dec 6, 2022
@jltng jltng added this to the Test files milestone Dec 6, 2022
@jltng jltng changed the title Features 7 - Tests and README Feature 7 - Tests and README Dec 6, 2022
jltng added 16 commits December 7, 2022 01:35
@jltng
pulling changes from main (idk why im getting a problem with my edito…
ef242e4 
…r (vi)
@jltng
bruh
eb08aa2
@jltng
updating branch with main
f9c9a38
@jltng
Merge branch 'main' into feature-7-tests-readme
429e25d
@jltng
merging main updates into local branch
0f45cac 
Merge branch 'main' into feature-7-tests-readme
@jltng
more debugging and shifting around: removed existence of 'enrolmentus…
c76e336 
…ergateway' because i don't need any other user's data except for the current user and i can just call that class. removing dependency to fileuser gets my enrolment main to work again so yay, main still broken
@jltng
minor fix in screen naming for instructor assignment creation, skelet…
f74d353 
…on of interactor test laid out
@jltng
minor fix in screen naming for instructor assignment creation, skelet…
18686ce 
…on of interactor test laid out
@jltng
pulling code cleanup branch
cde065d
@jltng
pulling code cleanup branch
cf4b1b2
@jltng
enrolment interactor testing
789633b
@jltng
debug enrolment: object copy,
76ae49f 
added getAssignmentCopy and getTestCopy in Assignment and Test entities
@jltng
task map to taskmap tests + debugging
12a9746
@jltng
task map updating bug should be fixed
62b7878
@jltng
COURSE ENROLMENT BUGS FINALLY FIXED PLS
1a96309
@jltng
Merging main branch updates into remote branche branch 'main' into fe…
c6059a8 
…ature-7-tests-readme
@jltng jltng added the (de)bug (Fixing) something that isn't working label Dec 9, 2022
sshmuylovich
sshmuylovich previously approved these changes Dec 9, 2022
View reviewed changes
@sshmuylovich sshmuylovich self-requested a review December 9, 2022 02:12
sshmuylovich
sshmuylovich previously approved these changes Dec 9, 2022
View reviewed changes
@jltng jltng added the documentation Improvements or additions to documentation label Dec 9, 2022
CC-3636
CC-3636 approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@CC-3636 CC-3636 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the tests, looks good :)

@jltng jltng merged commit f8cbad5 into main Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celinelumqr celinelumqr celinelumqr approved these changes

@CC-3636 CC-3636 CC-3636 approved these changes

@yyutiw yyutiw yyutiw approved these changes

@sshmuylovich sshmuylovich sshmuylovich left review comments

@alyson647 alyson647 Awaiting requested review from alyson647

@TiareMar TiareMar Awaiting requested review from TiareMar

Assignees

@jltng jltng

Labels
(de)bug (Fixing) something that isn't working documentation Improvements or additions to documentation tests Testing
Projects
None yet
Milestone
Test files
Development

Successfully merging this pull request may close these issues.

README Description
5 participants
@jltng @yyutiw @sshmuylovich @CC-3636 @celinelumqr