Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature 7 debugging + feature refinement #54

Merged
merged 29 commits into from
Dec 5, 2022
Merged

Feature 7 debugging + feature refinement #54

merged 29 commits into from
Dec 5, 2022

Conversation

jltng
Copy link
Contributor

@jltng jltng commented Nov 26, 2022 •
edited
Loading

CHANGES MADE:

  • updated use cases and screens follow serialization method shown in lecture (FileCourse)
  • added Javadocs for classes and methods
  • unused screens and CourseMap commented out, @TiareMar changed to a FileCourse class that implements the gateways of different use cases
  • serialization works!! for course creation at least not too sure about enrolment
  • unit tests for Course entity completed

Course Creation:

  • Course creation will not be creating tasks at the same time now (tasks will have to be created beforehand)
  • interactor completed (Note: currently uncommented out checks for whether task id exists in database for the sake of code running since taskmap is not initialized)

Course Enrolment:

  • interactor: did not end up calling task creation request model and implemented all the steps (most likely is a code smell and solid/clean violation)
  • added another gateway for adding courses to student's to do list (separated by functionality and data file accessed)

TO-DO / BUGS:

  • save TaskMap changes
  • will need to edit files after @CC-3636 and @yyutiw 's branches are merged
  • FileCourse test

Course Creation:

  • screen: finish action performed method (need to be looping through tasks arraylist and appending to tasks parameter)
  • working interactor test

Course Enrolment:

  • Currently unable to access students from users.ser, will need a static getAccounts() method
  • working interactor test

@jltng jltng self-assigned this Nov 26, 2022
@jltng jltng linked an issue Nov 26, 2022 that may be closed by this pull request
Feature 7 - Course Enrolment and Course Creation #16
Open
4 tasks
jltng added 2 commits November 26, 2022 17:46
@jltng
attempt to create new Task objects with course tasks entered by instr…
55e8b10 
…uctor user in course creation user case (unable to, Task is abstract), CourseEnrolmentDsGateway commented out + will be removed as don't think it is needed, adding course enrolment screen to Main (does not run, need to debug)
@jltng
serialization? serialization ;/ ...
28c055a
celinelumqr
celinelumqr previously approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@celinelumqr celinelumqr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good adherence to clean architecture as far as I can tell.

CC-3636
CC-3636 previously approved these changes Nov 29, 2022
View reviewed changes
@jltng jltng dismissed stale reviews from CC-3636 and celinelumqr via abbe8cf November 29, 2022 18:48
celinelumqr
celinelumqr previously approved these changes Nov 30, 2022
View reviewed changes
jltng and others added 6 commits December 1, 2022 01:38
@jltng
course creation use case implementation using filecourse and gateway …
c9ee374 
…(was unable to run main due to javacompile error - natalie i see you - but hopefully the serialization works ...)
@jltng
Delete CourseCreationMain.java
efb2ef8 
not meant to be pushed, for personal testing purposes only
@jltng
Delete CourseEnrolmentMain.java
6d74a88 
should not have been pushed
@jltng
commented out tests to pass workflow autograding
4f249a8
@jltng
Merge remote-tracking branch 'origin/feature-7-enrolment-persistence-…
3201a1a 
…tests' into feature-7-enrolment-persistence-tests
@jltng
Added javadocs, fixed some warnings, both use case follows serializat…
e53a1a3 
…ion method, unsused screens commented out, CourseMap commented out
@jltng jltng added (de)bug (Fixing) something that isn't working documentation Improvements or additions to documentation enhancement New feature or request code style / organization Refactoring and making code clean labels Dec 1, 2022
@jltng
course creation bug fixed (serialization works yay), changed location…
d75cf0c 
… of courses ser hopefully that doesn't break anything
jltng added 3 commits December 1, 2022 21:19
@jltng
wrote course unit tests (some don't pass rip) and interactor tests (a…
547eb60 
…lso don't pass), modified inmemorycourse for interactor tests
@jltng
Course Unit Test (commented out failed tests oop), found error with M…
d872031 
…ain running -- cannot seem to move the path of the ser file which is interesting
@jltng
added use case screens to main
8ab2714
@jltng jltng added the tests Testing label Dec 2, 2022
jltng added 3 commits December 2, 2022 02:57
@jltng
finished implementation for second half of course enrolment use case …
430d26d 
…(cloning course's task with a different task id, adding to task map, then adding to student's to do list. currently cannot access student from fileuser
@jltng
course unit tests now pass (modified course bool method), interactor …
0bfe10b 
…test still don't, added saveCourse in saveStudentToCourse (used in enrolment interactor), corrected addCourse method for student
@jltng
jk unit tests should work now
824b316
@jltng
realized tasks is "task 1, task2" instead of ["task1", "task2"] so ma…
1d9f0e1 
…de changes. enrolment interactor runs but does not seem to read filecourse properly?
@jltng jltng removed documentation Improvements or additions to documentation tests Testing labels Dec 3, 2022
jltng added 3 commits December 3, 2022 12:20
@jltng
pulled main branch edits, added a new gateway for enrolment (one gate…
2e6ad5b 
…way for each data file), gateway implemented by fileuser + added necessary methods in fileuser (currently commented out for sake of code running), finish enrolment interactor, screen, and main
@jltng
commented out tests to resolve autograding fail
07b4f7d
@jltng
commented out tests to resolve autograding fail
1d05266
celinelumqr
celinelumqr previously approved these changes Dec 4, 2022
View reviewed changes
celinelumqr
celinelumqr previously approved these changes Dec 5, 2022
View reviewed changes
@jltng jltng merged commit 3f503f1 into main Dec 5, 2022
@jltng jltng mentioned this pull request Dec 4, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celinelumqr celinelumqr celinelumqr approved these changes

@CC-3636 CC-3636 CC-3636 approved these changes

@TiareMar TiareMar TiareMar approved these changes

@yyutiw yyutiw Awaiting requested review from yyutiw

@alyson647 alyson647 Awaiting requested review from alyson647

@sshmuylovich sshmuylovich Awaiting requested review from sshmuylovich

Assignees

@jltng jltng

Labels
code style / organization Refactoring and making code clean (de)bug (Fixing) something that isn't working enhancement New feature or request
Projects
None yet
Milestone
Debugging, Fully Functional Program
Development

Successfully merging this pull request may close these issues.

Feature 7 - Course Enrolment and Course Creation
4 participants
@jltng @TiareMar @CC-3636 @celinelumqr