Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1 - User login & registration - Javadoc comments, testing, and other fixes. #42

Merged
merged 4 commits into from
Nov 22, 2022

Conversation

CC-3636
Copy link
Contributor

@CC-3636 CC-3636 commented Nov 21, 2022

Added javadoc comments to all use cases, but not to anything in the screens package yet.

@CC-3636 CC-3636 changed the title Javadoc comments, testing, and other fixes. Feature 1 - User login & registration - Javadoc comments, testing, and other fixes. Nov 21, 2022
@jltng jltng added the documentation Improvements or additions to documentation label Nov 21, 2022
@jltng jltng linked an issue Nov 21, 2022 that may be closed by this pull request
4 tasks
Copy link
Contributor

@sshmuylovich sshmuylovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confused as to why there are only java docs for some of the public methods and not all of them.

Also, it can be helpful for readability to distinguish parameter names when writing java docs because while on IntelliJ they are different colors, that isn't the case on GitHub and this would improve readability.
`/**

  • @param login - the login response...
  • /`

TiareMar
TiareMar previously approved these changes Nov 21, 2022
Copy link
Contributor

@jltng jltng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jltng jltng requested a review from alyson647 November 22, 2022 16:07
@celinelumqr celinelumqr merged commit 1d38186 into main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature 1 - User Registration & Log In
6 participants