feature 7 course creation + course enrolment + tasks to tasklist use cases #34
Conversation
merge updates on main branch to my local branch
…, controller and main file
…l, commented out ds request model file
…into Feature-7-Core-Functionalities
jltng
requested review from
CC-3636,
alyson647,
celinelumqr,
sshmuylovich,
TiareMar and
yyutiw
There was a problem hiding this comment.
Coding style: Class, package, and variable names all follow proper naming conventions and clearly describe their purpose (thank you for changing my entities package to lowercase).
Packaging: Good organization of code into entities/use cases/screens
Clean arch: Implementation of use cases follow clean architecture and SOLID principles very well
Javadoc: Good documentation of code, each step is mostly labeled. However, documentation is missing for most methods/constructors.
Approving because there are no major issues present
| } | ||
|
|
||
| /** | ||
| * Change getters to public? |
…a persistence and tests)
…ompleted, and documentation added (minus data persistence and tests)
…rsistence and tests)
There was a problem hiding this comment.
No major problems in code, although testing and java documentation still need to be completed.
Good packaging organization and naming conventions followed well.
As far as I can see, no big SOLID or Clean Architecture violations.
Approving in the interest of getting our program working first, and then fixing all the smaller issues later.
|
request closed because created new branch and merged use case files |
EDIT: New branch "feature 7 merge conflicts" is the duplicate branch
There is a lot of things going on even more things that need to be fixed!
For task creation:
CourseEnrolmentInteractor
Need to still add student id to Course object’s list of students in CourseMap, save and update, and then send success view to presenter
tasks_to_tasklist_use_case
Needs to be implemented, one of the TAs said that since it's returning a simple data structure (only a succcess view message) there is a particular way to do it .... I shall ask them during the week to figure it out
test cases:
to be finished