7 feature 4 forming user groups task creation #32

sshmuylovich · 2022-11-19T20:23:30Z

This should be all entities for my feature basically complete. Will be pushing use cases and then UI soon.

… correctly.

…nd declinedteammates. Added get and set methods for leader. Changed setRecurring so that recurring could be changed as well as frequency. Added java doc comments to all methods.

…eceiver so that it is just one Student User instead of an ArrayList of Student Users. Modified constructor accordingly.

…task-creation' into 7-feature-4-forming-user-groups-task-creation

sshmuylovich · 2022-11-19T20:26:25Z

Also, does any one know why workflow is failing?

sshmuylovich · 2022-11-19T20:33:57Z

Also not 100% whether my methods are correctly public vs protected so if any one has any strong opinions because of how their feature interacts with a method please let me know.

src/main/java/entities/CollaborativeTask.java

yyutiw

This is my bad because I keep noticing issues in Task, but just delete the 3 abstract methods and everything should match again.
Aside from that your implementation looks good to me!

src/main/java/entities/CollaborativeTask.java

src/main/java/Entities/CollaborativeTask.java

alyson647 · 2022-11-19T23:46:36Z

src/main/java/Entities/CollaborativeTask.java

+    private ArrayList<StudentUser> pendingTeammates;
+    private ArrayList<StudentUser> declinedTeammates;
+    private StudentUser leader;
+


For collaborative scheduling a deadline instance variable is needed as well. So like: private LocalDateTime deadline. This would also need a getter method and I think you have to add it to your constructor since the deadline can't have a default value.

Added two new constructor and getter/setter methods for new attribute.

Would you ever need a Collaborative "Test" or "Assignment"? I am thinking of making CollaborativeEvent a subclass of Event and CollaborativeAssignment a subclass of Assignment. Let me know what you think of that idea @yyutiw @alyson647

@sshmuylovich I'm not too sure about the idea to be honest. I viewed CollaborativeTask as separate to Test, Assignment, Event, and that it was its own thing since in our CRC cards it seemed like that. So, I don't know but I think that might complicate things a bit if we decide to make other entities like CollaborativeEvent, etc. It would also impact the functionality of my use case since I heavily rely on CollaborativeTask.

@sshmuylovich @alyson647 Yeah, I'd say collaborative tasks could be something like "work on assignment" or "study for test" anyways so splitting them up further would probably overcomplicate things

jltng

I don't think I use any of these entities, but yeah as mentioned above, necessary getters and setters would have to be public. Other than that, packages should be entities instead of Entities. Looks good and love the documentation!

…ed getter methods for frequency and recurring.

sshmuylovich · 2022-11-20T06:37:08Z

Note that I am showing an error for Collaborative Task at the moment because my version of Task still has edit, delete, and save as abstract classes that I no longer include in Collaborative Task as per Yuti's comments.

yyutiw

Looks good overall

src/main/java/entities/CollaborativeTask.java

jltng

Looks good!

jltng · 2022-11-22T01:13:14Z

src/main/java/entities/internalUserList.java

+
+import java.util.ArrayList;
+
+public class internalUserList {


I believe @CC-3636 has this file as well as UserWhisperer removed (she no longer uses these entities anymore). Double check with her though

correct, I removed both UserWhisperer and internalUserList because I no longer use them

CC-3636

I deleted UserWhisperer -- the create method is now a part of UserFactory. I also got rid of internalUserList because we are using an external User Database.

jltng

Looks great!

…move methods to one set method.

…dit_use_case

CC-3636

thanks for making the changes I requested :)

sshmuylovich and others added 9 commits November 1, 2022 17:10

Added CollaborativeTask and Invitation Classes.

3df2fd6

Added CollaborativeTask and Invitation Classes.

57c5f56

Renamed directory folder entities to Entities so imports were working…

2400f35

… correctly.

Added get, add, and remove methods for teammates, pendingteammates, a…

7beb17c

…nd declinedteammates. Added get and set methods for leader. Changed setRecurring so that recurring could be changed as well as frequency. Added java doc comments to all methods.

Added method bodies for setTitle and setPriority.

1c9b194

Added all methods with java doc comments. Changed instance variable r…

e11d67d

…eceiver so that it is just one Student User instead of an ArrayList of Student Users. Modified constructor accordingly.

entities changed to Entities.

3b37e76

Merge remote-tracking branch 'origin/7-feature-4-forming-user-groups-…

61ef0ad

…task-creation' into 7-feature-4-forming-user-groups-task-creation

Changes disappeared when merging. Bringing them back.

e78a8de

sshmuylovich requested review from yyutiw, jltng, CC-3636, alyson647 and celinelumqr November 19, 2022 20:23

CreateNewCollaborativeTaskUseCase added

495ed89

yyutiw reviewed Nov 19, 2022

View reviewed changes

src/main/java/entities/CollaborativeTask.java Show resolved Hide resolved

yyutiw reviewed Nov 19, 2022

View reviewed changes

src/main/java/entities/CollaborativeTask.java Show resolved Hide resolved

alyson647 reviewed Nov 19, 2022

View reviewed changes

jltng previously requested changes Nov 20, 2022

View reviewed changes

sshmuylovich added 4 commits November 20, 2022 01:21

Changed TimeBlock attributes according to code reviews by Alyson. Add…

175f406

…ed getter methods for frequency and recurring.

Changed protected methods to public.

ef36c85

Added deadline attribute, more constructors, getter and setter methods.

83978d3

Deleted Use Case package for now.

f582acb

sshmuylovich requested review from yyutiw, alyson647 and jltng November 20, 2022 07:01

jltng assigned sshmuylovich Nov 20, 2022

yyutiw previously approved these changes Nov 22, 2022

View reviewed changes

src/main/java/entities/CollaborativeTask.java Show resolved Hide resolved

jltng previously approved these changes Nov 22, 2022

View reviewed changes

Priority param in java doc for CollaborativeTask constructor.

f88b795

sshmuylovich dismissed stale reviews from jltng, yyutiw, and alyson647 via f88b795 November 22, 2022 01:10

sshmuylovich requested review from yyutiw, alyson647 and jltng November 22, 2022 01:11

jltng reviewed Nov 22, 2022

View reviewed changes

yyutiw previously approved these changes Nov 22, 2022

View reviewed changes

CC-3636 reviewed Nov 22, 2022

View reviewed changes

Delete internalUserList.java and UserWhisperer.java

124d80d

sshmuylovich dismissed yyutiw’s stale review via 124d80d November 22, 2022 02:16

sshmuylovich requested review from jltng, yyutiw and CC-3636 November 22, 2022 02:16

jltng previously approved these changes Nov 22, 2022

View reviewed changes

yyutiw previously approved these changes Nov 22, 2022

View reviewed changes

Changed teammates, pendingTeammates, and declinedTeammates add and re…

18c5927

…move methods to one set method.

sshmuylovich dismissed stale reviews from yyutiw and jltng via 18c5927 November 22, 2022 02:49

Created collaborative_task_creation_use_case and collaborative_task_e…

8383ab2

…dit_use_case

sshmuylovich requested review from yyutiw and jltng November 22, 2022 02:54

jltng approved these changes Nov 22, 2022

View reviewed changes

CC-3636 approved these changes Nov 22, 2022

View reviewed changes

alyson647 approved these changes Nov 22, 2022

View reviewed changes

sshmuylovich merged commit c75d476 into main Nov 22, 2022

sshmuylovich linked an issue Nov 22, 2022 that may be closed by this pull request

Feature 4 - Forming User Groups & Task Creation #7

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

7 feature 4 forming user groups task creation #32

7 feature 4 forming user groups task creation #32

sshmuylovich commented Nov 19, 2022 •

edited

Loading

sshmuylovich commented Nov 19, 2022

sshmuylovich commented Nov 19, 2022

yyutiw left a comment

alyson647 Nov 19, 2022

sshmuylovich Nov 20, 2022

sshmuylovich Nov 20, 2022

alyson647 Nov 20, 2022 •

edited

Loading

yyutiw Nov 22, 2022

jltng left a comment

sshmuylovich commented Nov 20, 2022 •

edited

Loading

yyutiw left a comment

jltng left a comment

jltng Nov 22, 2022 •

edited

Loading

CC-3636 Nov 22, 2022

CC-3636 left a comment

jltng left a comment

CC-3636 left a comment

7 feature 4 forming user groups task creation #32

7 feature 4 forming user groups task creation #32

Conversation

sshmuylovich commented Nov 19, 2022 • edited Loading

sshmuylovich commented Nov 19, 2022

sshmuylovich commented Nov 19, 2022

yyutiw left a comment

Choose a reason for hiding this comment

alyson647 Nov 19, 2022

Choose a reason for hiding this comment

sshmuylovich Nov 20, 2022

Choose a reason for hiding this comment

sshmuylovich Nov 20, 2022

Choose a reason for hiding this comment

alyson647 Nov 20, 2022 • edited Loading

Choose a reason for hiding this comment

yyutiw Nov 22, 2022

Choose a reason for hiding this comment

jltng left a comment

Choose a reason for hiding this comment

sshmuylovich commented Nov 20, 2022 • edited Loading

yyutiw left a comment

Choose a reason for hiding this comment

jltng left a comment

Choose a reason for hiding this comment

jltng Nov 22, 2022 • edited Loading

Choose a reason for hiding this comment

CC-3636 Nov 22, 2022

Choose a reason for hiding this comment

CC-3636 left a comment

Choose a reason for hiding this comment

jltng left a comment

Choose a reason for hiding this comment

CC-3636 left a comment

Choose a reason for hiding this comment

sshmuylovich commented Nov 19, 2022 •

edited

Loading

alyson647 Nov 20, 2022 •

edited

Loading

sshmuylovich commented Nov 20, 2022 •

edited

Loading

jltng Nov 22, 2022 •

edited

Loading