Adding Time Index To HealthKit Sample Uploads #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Time Index To HealthKit Sample Uploads
♻️ Current situation & Problem
As we are transitioning the backend to an architecture that doesn't depend on cloud functions and periodic featurization, we are working on efficient data fetching queries in Firebase. Many HealthKit data types are associated with a time range, not a timestamp. This complicates Firebase queries since queries like
are not permitted due to inequality filters on multiple properties.
Instead, I am proposing adding the following fields to each HealthKit upload:
in addition, we will also have ranges for each time index component, such as
which will allow us to make efficient Firebase array membership queries
⚙️ Release Notes
constructTimeIndex
in a newPrismaStandard+TimeIndex.swift
that computes the necessary time fields📚 Documentation
N/A
✅ Testing
N/A
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: