Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bytes literal in hugr-model. #1845

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Bytes literal in hugr-model. #1845

wants to merge 1 commit into from

Conversation

zrho
Copy link
Contributor

@zrho zrho commented Jan 8, 2025

Adds a term for byte literals to hugr-model.

In the text format, byte literals are represented as base64 encoded strings.

Closes #1545.

@zrho zrho force-pushed the zrho/model-bytes branch from 4b31d2b to 70cf77b Compare January 8, 2025 15:47
@hugrbot
Copy link
Collaborator

hugrbot commented Jan 8, 2025

This PR contains breaking changes to the public Rust API.
Please deprecate the old API instead (if possible), or mark the PR with a ! to indicate a breaking change.

cargo-semver-checks summary

--- failure enum_variant_added: enum variant added on exhaustive enum ---

Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
      ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/enum_variant_added.ron

Failed in:
variant Term:Bytes in /home/runner/work/hugr/hugr/PR_BRANCH/hugr-model/src/v0/mod.rs:691
variant Term:BytesType in /home/runner/work/hugr/hugr/PR_BRANCH/hugr-model/src/v0/mod.rs:697

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 81.08108% with 7 lines in your changes missing coverage. Please review.

Project coverage is 86.55%. Comparing base (774a13e) to head (6972f60).

Files with missing lines Patch % Lines
hugr-core/src/import.rs 0.00% 3 Missing ⚠️
hugr-model/src/v0/text/parse.rs 70.00% 1 Missing and 2 partials ⚠️
hugr-model/src/v0/binary/read.rs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1845      +/-   ##
==========================================
- Coverage   86.55%   86.55%   -0.01%     
==========================================
  Files         194      194              
  Lines       35156    35193      +37     
  Branches    31969    32006      +37     
==========================================
+ Hits        30430    30462      +32     
- Misses       2968     2970       +2     
- Partials     1758     1761       +3     
Flag Coverage Δ
python 92.31% <ø> (ø)
rust 85.98% <81.08%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zrho zrho force-pushed the zrho/model-bytes branch from 70cf77b to 6972f60 Compare January 10, 2025 13:06
@zrho zrho marked this pull request as ready for review January 10, 2025 13:13
@zrho zrho requested a review from a team as a code owner January 10, 2025 13:13
@zrho zrho requested a review from tatiana-s January 10, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

model: Add terms for bytes
2 participants