Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QPPA-8312: added mock AdminClaim and cost data #732

Merged
merged 2 commits into from
Nov 17, 2023
Merged

QPPA-8312: added mock AdminClaim and cost data #732

merged 2 commits into from
Nov 17, 2023

Conversation

ckawell-sb
Copy link
Contributor

@ckawell-sb ckawell-sb commented Nov 16, 2023 •
edited
Loading

ICF

Related Tickets & Documents

https://jira.cms.gov/browse/QPPA-8312

Description

See ticket description.

What type of PR is this?

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore
  • ⏩ Revert

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 Confluence
  • 🙅 no documentation needed

ckawell-sb
ckawell-sb commented Nov 16, 2023
View reviewed changes
scripts/benchmarks/csv-json-converter.ts
@@ -63,7 +63,9 @@ function convertCsvToJson(csvPath: string, performanceYear: number, jsonFileName

//populate some default values if they are not found in the csv.
measure.isToppedOutByProgram = measure.isToppedOutByProgram || false;
measure.averagePerformanceRate = measure.averagePerformanceRate || null;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code change is to auto update the averagePerformanceRate value and set it as a number instead of a string.

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ckawell-sb ckawell-sb mentioned this pull request Nov 16, 2023
Closed
16 tasks
@ckawell-sb ckawell-sb merged commit 2daa5cb into develop Nov 17, 2023
3 checks passed
@ckawell-sb ckawell-sb deleted the feat/QPPA-8312 branch November 17, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peg-uehling peg-uehling peg-uehling approved these changes

@john-manack john-manack john-manack approved these changes

@saquino0827 saquino0827 Awaiting requested review from saquino0827

@KyleApfel KyleApfel Awaiting requested review from KyleApfel KyleApfel is a code owner

@michelingle michelingle Awaiting requested review from michelingle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ckawell-sb @john-manack @peg-uehling