Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QPPSE-1425: Add BR-018s to exclusion reasons #730

Merged
merged 5 commits into from
Nov 20, 2023
Merged

QPPSE-1425: Add BR-018s to exclusion reasons #730

merged 5 commits into from
Nov 20, 2023

Conversation

pkasarski
Copy link
Contributor

ICF


Related Tickets & Documents

https://jira.cms.gov/browse/QPPA-XXXX


Description

See ticket description.


What type of PR is this?

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore
  • ⏩ Revert

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ Confluence
  • πŸ™… no documentation needed

[ βŒ₯ Optional ] Are there any post-deployment tasks we need to perform?


[ βŒ₯ Optional] What gif best describes this PR or how it makes you feel?

varunkarne
varunkarne previously approved these changes Nov 17, 2023
Copy link

@michelingle michelingle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkasarski even if there is already a reasonCode (because there are not 20 cases), we need to update the reasonCode to "BR-018". Measure:SubmissionMethods that need to be updated:

  1. 335: registry
  2. 366: eCQM
  3. 409: registry

Copy link

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pkasarski
Copy link
Contributor Author

@pkasarski even if there is already a reasonCode (because there are not 20 cases), we need to update the reasonCode to "BR-018". Measure:SubmissionMethods that need to be updated:

  1. 335: registry
  2. 366: eCQM
  3. 409: registry

Done.

@pkasarski pkasarski merged commit 48e0aa0 into develop Nov 20, 2023
3 checks passed
@pkasarski pkasarski deleted the qppse-1425 branch November 20, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants