facility-create-edit #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o reuse common colours in app
Closed
…o-database' into US-02.01.03
# Conflicts: # src/app/src/main/res/drawable/edit_text_box.xml # src/app/src/main/res/values/colors.xml
# Conflicts: # src/app/src/main/java/com/example/myapplication/EntrantStatus.java # src/app/src/main/java/com/example/myapplication/Event.java # src/app/src/main/java/com/example/myapplication/Facility.java # src/app/src/main/java/com/example/myapplication/User.java
…01.03 # Conflicts: # src/app/src/main/java/com/example/myapplication/EntrantStatus.java # src/app/src/main/java/com/example/myapplication/Event.java # src/app/src/main/java/com/example/myapplication/Facility.java # src/app/src/main/java/com/example/myapplication/User.java
|
tested the address string to latlng conversion for facility location manually since its a method in the facility creation/edit fragments. Should I just make this method its own class since it is being reused twice and write a unit test for it? |
that's a good idea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notice:
I have done basic testing for these stories manually by merging the implementing-navigation branch and this one into a test branch (test-facility-create-edit-nav).
before merging: