Project 4: TOM DONNELLY #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…structions-2021 Update instructions for Fall 2021
Updated dates
Added GUIDataContainer Class to bridge data communication between pathtrace.cu and preview.cpp
Currently it's impossible to "unfocus" the GUI because a bool variable is not updated correctly.
Fix a bug that causes MouseOverImGuiWindow() to not work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repo Link
Note: Did not test all project3 path tracer features, namely dof and checkpointing with denosiing. There is also a base implementation in the base code of my project 4 repo using provided code
Feeback:
Cool project! Maybe make it more ML based in the future? The differences in how imGUI features are implemented between the project 3 and 4 made debugging it a big pain. Having a dummy control window in project 3 might be useful just so its not hard to merge the two later