Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update derecho gnu, add code coverage capability via lcov #510

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update derecho gnu, add code coverage capability via lcov #510

wants to merge 4 commits into from

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Jan 16, 2025 •
edited
Loading

PR checklist

  • Short (1 sentence) summary of your PR:
    Update derecho gnu, add code coverage capability via lcov
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Results all pass, non-debug tests change answer on derecho gnu with addition of -O2. https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash_forks#3d8b76b9194718c332cc3706f009e8ddc186cd5f
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit, answer changing on derecho gnu due to compiler upgrade
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.

Update derecho gnu to support code coverage testing

  • Update to ncarenv/24.12 and gcc/12.4.0
  • Add coverage compiler flags
  • Add parse_lcov.sh script to support manually parsing lcov info files (not used in production)
  • Update lcov scripting as needed

Change derecho gnu non-debug tests to -O2. This should have always been the case, but was not. This results in answers changes relative to main but only for derecho gnu with debug off.

As part of the CICE port to the new coverage tools, a bug was found in the tools that requires debug flags to be disabled when compiling with coverage flags. This was not the case when coverage was running on cheyenne. See linux-test-project/lcov#385

@apcraig
Update derecho gnu env to ncarenv/23.09 and gcc/13.2.0. Check lcov code
d91701f 
coverage tool.  Add parse_lcov to provide overall coverage info while genhtml
is not working due to perl modules.
@apcraig
Update derecho gnu to ncarenv/24.12 and gcc/12.4.0 for support for
ca390d0 
lcov coverage tool.  Bit for bit with ncarenv/12.06 and gcc/12.2.0.
@apcraig
Update machine documentation
1766f55
@apcraig
Update derecho gnu to -O2, was missing for reasons unknown. Update
3d8b76b 
the Macros coverage flag logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabail10 dabail10 dabail10 approved these changes

@eclare108213 eclare108213 eclare108213 approved these changes

@anton-seaice anton-seaice Awaiting requested review from anton-seaice

Assignees
No one assigned
Labels
Porting Scripts Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apcraig @eclare108213 @dabail10