Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newgrid #920

Closed
wants to merge 3 commits into from
Closed

Newgrid #920

wants to merge 3 commits into from

Conversation

TillRasmussen
Copy link
Contributor

@TillRasmussen TillRasmussen commented Dec 17, 2023 •
edited
Loading

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Reduce and remove arrays not needed from ice_grid
  • Developer(s):
    Till Rasmussen, DMI
  • [ x] Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Bit for Bit
  • How much do the PR code changes differ from the unmodified code?
    • [ x] bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • [x ] No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • [ x] No
  • Does this PR add any new test cases?
    • Yes
    • [ x] No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • [ x] No, does the documentation need to be updated at a later time?
      • Yes
      • [ x] No
  • Please provide any additional information or relevant details below:
    Changes according to these principles
    a/ If not used remove
    b/ If only used in specific modules move there and allocate when needed.
    In ice_grid:
    1/ Removed mne, mnw, mse, msw. Not used. Points to remapping
    2/ xav, yav, xxav, yyav changed to paremeters and moved to remapping where they are used. First two are 0. Should be removed. The latter two are 1/12. An interface was needed as subroutine limited_gradient required input as array. This could probably be fixed in alternative ways.
    3/ Moved cyp, cxp, cym, cxm, dxhy, dyhx. Moved to ice_dyn_shared. Only allocate when 2d B-grid (EAP, EVP, VP).
    Moved ratiodxN, ratiodyE, ratiodxNr, ratiodyEr to ice_dyn_evp. Only allocated when C grid
    @dabail10 Many grid parameters are set to 1e36 within CESM cpp flag. I cannot really check. any preferences for what to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apcraig apcraig Awaiting requested review from apcraig

@eclare108213 eclare108213 Awaiting requested review from eclare108213

@dabail10 dabail10 Awaiting requested review from dabail10

@phil-blain phil-blain Awaiting requested review from phil-blain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TillRasmussen