add sycl backend #771
Draft
add sycl backend #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasahi-hpc
commented
Feb 10, 2025
| #elif defined(KOKKOS_ENABLE_SYCL) | ||
| else if constexpr (std::is_same_v<MemorySpace, Kokkos::SYCLDeviceUSMSpace>) { | ||
| return m_device_on_host; | ||
| } | ||
| #endif | ||
| else { | ||
| static_assert(!std::is_same_v<MemorySpace, MemorySpace>); |
There was a problem hiding this comment.
Is this line meaningful? @tpadioleau
static_assert(!std::is_same_v<MemorySpace, MemorySpace>);
There was a problem hiding this comment.
Should be, ideally i would like to put false but the compiler will then stop compiling even if the branch is not chosen
No need to address the last point. I will do it in an other PR. |
Good. I will rebase on top of that |
|
closes #73 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at adding a SYCL backend to DDC.
KOKKOS_ENABLE_CUDAandKOKKOS_ENABLE_HIPinstead of__CUDACC__and__HIPCC__Typical build command would be as follows.
cmake -B build -DCMAKE_CXX_COMPILER=icpx \ -DDDC_BUILD_KERNELS_FFT=OFF \ -DDDC_BUILD_KERNELS_SPLINES=ON \ -DDDC_BUILD_PDI_WRAPPER=OFF \ -DKokkos_ENABLE_SYCL=ON \ -DKokkos_ARCH_INTEL_PVC=ON \ -DKokkos_ENABLE_SYCL_RELOCATABLE_DEVICE_CODE=ON