-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding additional logging and configuration #11
Conversation
It seems that moving the version file angers the backend compilation in the CI/CD github pipeline. Got this from lines 494-504 of the build log
I confirmed that it didn't do this previously here |
@jfreuden REALLY good catch. Wow I cannot believe the action passed even though it threw. I investigated it and it looks like Docker is once again the problem, Second being the fact that the Decky build tool requires the docker command to be run in a specific way. I think in future I will want to expand the tool to allow arbitrary binds (so I can just mount the file in the right location) but for the moment it looks like I will have to once again swap them around so the "original" is in the backend folder... I really wish that docker let you copy a file from outside its directory :/ |
a124d72
to
0b604ad
Compare
c54eddf
to
198528e
Compare
I saw that you fixed the version error as well as got rid of the warnings. Did you ever figure out how to ensure the Action sees a compile error of |
Not yet. the docker run command succeeds even if the process fails. I need to find a way for the docker container to exit with the same status code as the process did. |
The build has
I'm not sure whether something similar needs to be done on the |
Well the good news is that my solution does make docker now see failures but the |
Wonderful, Thank you so much for helping fix that <3 |
I put a PR pointing to this branch, so that as you keep working on this PR the actions will only take a CLI update in order to show accurate runner statuses. I can also cherry pick it to point wherever, it doesn't really matter where it goes 😄 |
* Change the build-docker.sh file to return exit code from build According to rust-lang/cargo#3377 (comment) the cargo search doesn't update the index and later in the thread is pointed out this is unnecessary now. Which is good because this doesn't work anymore * Version bump of Decky CLI to 0.0.2 should fix the Github Runner failing to register error status codes from `cargo build` in backend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets hope I didn't miss anything :3
To aid in troubleshooting bug reports more information will be required. To this end the
log
crate is being replaced withtrace
which is a lot more powerful. A toml configuration file is also added to allow configuration of the backend, including the level the logs should be written as.