Story/672/marshal results into fhir #755
Conversation
…into story/672/marshal-results-into-fhir
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
etor/src/main/java/gov/hhs/cdc/trustedintermediary/external/hapi/HapiOrderConverter.java
Fixed
Show fixed
Hide fixed
| @@ -25,6 +25,15 @@ public PartnerMetadata( | |||
| this(receivedSubmissionId, null, sender, null, timeReceived, hash); | |||
| } | |||
|
|
|||
| public PartnerMetadata( | |||
There was a problem hiding this comment.
Yes in the PR to add Submission received id
There was a problem hiding this comment.
So it will be added in this PR, and then removed in the other one? Is that necessary?
| @@ -120,6 +123,7 @@ public synchronized PartnerMetadata fetchMetadata(String receivedSubmissionId) | |||
|
|
|||
| return new PartnerMetadata( | |||
| result.getString("message_id"), | |||
| result.getString("sender"), | |||
There was a problem hiding this comment.
Is this change going to be in the other PR that will add the sentSubmissionId handling?
etor/src/test/groovy/gov/hhs/cdc/trustedintermediary/etor/EtorDomainRegistrationTest.groovy
Outdated
Show resolved
Hide resolved
| Timestamp timestampForMock = Timestamp.from(Instant.parse("2024-01-03T15:45:33.30Z")) | ||
| Instant timeReceived = timestampForMock.toInstant() | ||
| def hash = receiver.hashCode().toString() | ||
| def expected = new PartnerMetadata(messageId, receiver, timeReceived, hash) | ||
| def hash = sender.hashCode().toString() |
There was a problem hiding this comment.
Should the changes to the DB implementation in this PR be in the other PR given is not directly related to the marshaling of the response?
There was a problem hiding this comment.
The above changes are fixing a bug I had from previous PRs, because of how I was retrieving results, one column from the db was never being populated. So I updated the above test after fixing the results retrieval as the test started to fail.
…com/CDCgov/trusted-intermediary into story/672/marshal-results-into-fhir
etor/src/main/java/gov/hhs/cdc/trustedintermediary/etor/orders/OrderConverter.java
Outdated
Show resolved
Hide resolved
|
#672
Marshaling our stored data into a FHIR object
Issue
Add a link to the issue here. Consider using
672
Checklist
Note: You may remove items that are not applicable