NTE Integration Test #1649
NTE Integration Test #1649
Conversation
Co-authored-by: basiliskus <[email protected]> Co-authored-by: Sylvie <[email protected]>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
PR Code Suggestions ✨No code suggestions found for the PR. |
Co-authored-by: Sylvie <[email protected]> Co-authored-by: basiliskus <[email protected]>
Co-authored-by: Sylvie <[email protected]> Co-authored-by: basiliskus <[email protected]>
Co-authored-by: Sylvie <[email protected]>
| "MSH-10 = '011'" | ||
| ], | ||
| "rules": [ | ||
| "NTE-3 = 'note 1'", |
There was a problem hiding this comment.
I understand why we are using this rule but I don't love it since it only works because our HL7 parser only returns the first iteration of each segment/field and there is no indexing.
There was a problem hiding this comment.
Consider using NTE-3 = input.NTE-3 which would work even if we add indexing
There was a problem hiding this comment.
Good point. Changed it
There was a problem hiding this comment.
I reran the automation test as well and it works.
| "MSH-10 = '011'" | ||
| ], | ||
| "rules": [ | ||
| "NTE-3 = 'note 1'", |
There was a problem hiding this comment.
Consider using NTE-3 = input.NTE-3 which would work even if we add indexing
|
Description
Added a new assertion to test that NTE segment exists after transformation from FHIR to HL7. This was tested by triggering the Automated Staging integration tests. It successfully ran with the right conditions, and successfully broke when the conditions were purposely fiddled with.
Issue
#1424
Checklist
Note: You may remove items that are not applicable