Skip to content

Commit

Permalink
Added a few more impact points
Browse files Browse the repository at this point in the history
  • Loading branch information
basiliskus committed Oct 4, 2024
1 parent 6fbfde6 commit 80487f7
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions adr/025-automated-rs-integration-test.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,18 @@ transformations that will overwrite HL7 fields used for routing (MSH-5 and MSH-6

### Negative

- We will run daily tests in RS' and our staging infrastructure, which will take up resources

### Risks

- If we forget to add additional assertions when new transformations are added, these tests may give us
a false sense of confidence
- Because we rely on MSH-10 for matching files, engineers will have to take care in setting this field
when they create additional tests in future
- If we don't maintain the filtering in RS based on MSH-6.2 and MSH-10, we may not be able to route the test messages
correctly
- Because we're using RS's existing REST endpoints and staging set up, if RS changes their endpoints or
the way they handle staging, these tests may break

## Related ADRs

Expand Down

0 comments on commit 80487f7

Please sign in to comment.