Fix spacing for date checkbox in queue item #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ov/prime-simplereport into emmastephenson/date-spacing
timbest-cdc
approved these changes
Mar 25, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
|
I'm just seeing this—Overall these changes look great but the checkbox looks like it shifts upwards when it moves to the right after being unchecked. Can keep it in-line w/ the input that appears? |
|
Sorry Heather, I didn't see your comment before merging. I tried to keep it in line with the date box input, but it does mess with spacing on mobile - the checkbox gets pushed down further (that's what the second GIF is). I can add a mobile-specific rule to fix that in a separate PR. |
|
Thanks, we aren't currently optimizing for mobile use so I wouldn't worry about that right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue or Background Info
https://app.zenhub.com/workspaces/simplereport-5ff8be8854ae8b000e378210/issues/cdcgov/prime-simplereport/682
Changes Proposed
Additional Comments
toptomargin-topin the checkbox improves the mobile view, but does space the desktop view differently. Screenshots of both are attached, I'm happy to switch from one to the other.Screenshots / Demos
margin-top:
top:
existing view:
