-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests to schema config reader and adjust tests for merging schema… #8741
Conversation
…s; account for constants and names when merging schemas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this with my branch and constants are working, nice! By the way something we tried to do to suppress AOEs was to override a constant in the extension schema. I tested that and it works too, but it may be worth adding a unit test for that, in case we need it in the future.
Covered Victor's suggestion in this commit, just waiting on another approval to merge. |
This PR adds a missing piece of the merge between two schemas. Previously, the merge would pull child schema elements into the parent schema, either by adding them straight in, or by merging them into an element within the parent schema, but the name of the resulting merged schema would still reflect the base schema and the constants from the child schema would be ignored. A couple lines of code was enough to fix that behavior.
As part of this, I adjust the unit tests to make sure we're checking the constants and the name of a schema post-merge.
Test Steps:
or
test read from file with extends
Changes
merge
function inConfigSchema.kt
to allow merging of two schemas'constants
andname
valuesConfigSchemaReaderTests.kt
ConverterSchemaTests.kt
andFhirTransformSchemaTests.kt
to exercise new code and to more closely verify behavior of inherited constants/names.Checklist
Testing
./prime test
or./gradlew testSmoke
against local Docker ReportStream container?Linked Issues