-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experience 16074: Create test result page without download results #16938
Experience 16074: Create test result page without download results #16938
Conversation
…ge' into experience/16074-Create-Test-Result-Page-without-Download-Results
Fixes #16074 - first pass
@jpandersen87 I chose to go with the single I 100% appreciate that in React v19 there's a new potential approach to forms, but I think we should focus on the feature at hand, and make a ticket to update our forms across the board if that's something we want to prioritize. I also consolidated some of the componentized pieces you broke out since they were small enough that I felt like it actually added complexity to go search for them (ie, Currently, this code uses |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
frontend-react/src/pages/admin/AdminMessageTestingPage/AdminMessageTestingPage.tsx
Outdated
Show resolved
Hide resolved
frontend-react/src/hooks/api/messages/UseTestMessageResult/UseTestMessageResult.ts
Show resolved
Hide resolved
frontend-react/src/pages/admin/AdminMessageTestingPage/AdminMessageTestingPage.tsx
Show resolved
Hide resolved
frontend-react/src/hooks/api/messages/UseTestMessageResult/UseTestMessageResult.ts
Show resolved
Hide resolved
@jillian-hammer updated top comment with full-page images of each state, parity with Figma design. |
thanks @etanb for the work & the screen recordings!! this is looking good! missing states
UX QA
content QA
|
@jillian-hammer made those updates (except Filter Trigger subsection since we need this ticket to be resolved first) with video proof: prUpdates.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think just the issue with returning the original tanquery hook data + custom properties on our hook is left.
Branch deployed to Chromatic 🚀.
View via: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @etanb for your work on this!
…hout-Download-Results
Quality Gate failedFailed conditions |
|
Select message 📸
Message test result: single error 📸
Message test result: multi error 📸
Message test result: expanded accordions 📸
Message test result: success 📸
Full test video: 🎥
messageTestDemo.mp4
Fixes #16074