Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experience 16074: Create test result page without download results #16938

Merged

Conversation

etanb
Copy link
Collaborator

@etanb etanb commented Dec 31, 2024

Select message 📸

screencapture-localhost-3000-admin-orgreceiversettings-org-ignore-receiver-FULL-ELR-action-edit-message-testing-2025-01-08-17_34_27

Message test result: single error 📸

screencapture-localhost-3000-admin-orgreceiversettings-org-ignore-receiver-FULL-ELR-action-edit-message-testing-2025-01-08-17_33_24

Message test result: multi error 📸

screencapture-localhost-3000-admin-orgreceiversettings-org-ignore-receiver-FULL-ELR-action-edit-message-testing-2025-01-08-17_34_55

Message test result: expanded accordions 📸

screencapture-localhost-3000-admin-orgreceiversettings-org-ignore-receiver-FULL-ELR-action-edit-message-testing-2025-01-08-17_35_11

Message test result: success 📸

screencapture-localhost-3000-admin-orgreceiversettings-org-ignore-receiver-FULL-ELR-action-edit-message-testing-2025-01-08-22_12_44

Full test video: 🎥

messageTestDemo.mp4

Fixes #16074

@etanb etanb added the experience Team label to flag issues owned by the Experience Team label Dec 31, 2024
@etanb
Copy link
Collaborator Author

etanb commented Dec 31, 2024

@jpandersen87 I chose to go with the single <form> approach for simplicity. I believe it helps with readability while centralizing the code logic a bit more.

I 100% appreciate that in React v19 there's a new potential approach to forms, but I think we should focus on the feature at hand, and make a ticket to update our forms across the board if that's something we want to prioritize. I also consolidated some of the componentized pieces you broke out since they were small enough that I felt like it actually added complexity to go search for them (ie, TestMessageLabel, MessageTestingBody etc).

Currently, this code uses AdminMessageTestingPage as a parent / wrapper component, and then it chooses between the two steps within the MessageTestingSteps enum. I've created a new hook called useTestMessageResult to get the validation from the B/E, but we have a little back-and-forth going if requests that don't have the correct responseType or other errors, should be 400 (which they currently are) or if they should be 200 with the issue as a response.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@etanb etanb added the trialfrontend03 Trigger a trialfrontend03 deployment label Jan 7, 2025
@etanb
Copy link
Collaborator Author

etanb commented Jan 9, 2025

@jillian-hammer updated top comment with full-page images of each state, parity with Figma design.

@jillian-hammer
Copy link
Collaborator

jillian-hammer commented Jan 9, 2025

thanks @etanb for the work & the screen recordings!! this is looking good!

missing states

  • Do you have a view with Warnings? I think the screenshots only cover the Error and Success states.
  • Does the Filters triggered section have the subsections for Quality filter and Condition filter built in? I don't see the current example being categorized as one or the other.

UX QA

  • After a user adds a custom message, can it then be auto-selected for them? (Reduces the need for multiple clicks at :07 in the screen recording). if this is more of a message bank comment lmk and we can hold on this.
  • The Output message should not appear if there are Errors. in other words, the Output message only appears if A) It passes with warnings or B) It passes successfully.

content QA

  • "Receiver transform warnings" should read "Transform warnings"
  • "Filter errors" should read "Filters triggered"

@etanb
Copy link
Collaborator Author

etanb commented Jan 11, 2025

@jillian-hammer made those updates (except Filter Trigger subsection since we need this ticket to be resolved first) with video proof:

prUpdates.mp4

Copy link
Collaborator

@jpandersen87 jpandersen87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just the issue with returning the original tanquery hook data + custom properties on our hook is left.

Copy link
Contributor

Branch deployed to Chromatic 🚀.

  • ⚠️ Detected 0 tests with visual changes.
  • ✅ All tests passed.

View via:

@etanb etanb marked this pull request as ready for review January 16, 2025 21:21
@etanb etanb requested a review from jpandersen87 January 23, 2025 21:14
Copy link
Collaborator

@jillian-hammer jillian-hammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @etanb for your work on this!

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@etanb etanb requested a review from victor-chaparro January 23, 2025 23:46
@etanb etanb enabled auto-merge January 24, 2025 00:28
@etanb etanb merged commit 1e0e737 into main Jan 24, 2025
29 of 31 checks passed
@etanb etanb deleted the experience/16074-Create-Test-Result-Page-without-Download-Results branch January 24, 2025 00:38
Copy link
Contributor

⚠️ Broken Links ⚠️

https://www.hhs.gov/vulnerability-disclosure-policy/index.html

Error: Request failed with status code 403


❌ /assets/xlsm/20241204_ReportStream-Mapping-Template.xlsm

Error: Internal link: Page error


https://www.cdc.gov/poxvirus/mpox/lab-personnel/report-results.html

Error: Request failed with status code 404


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experience Team label to flag issues owned by the Experience Team trialfrontend03 Trigger a trialfrontend03 deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Test Result Page (without "Download Results")
3 participants