Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform/david navapbc/14568/update fhir resource delete strategy #15814

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

david-navapbc
Copy link
Collaborator

This PR ...
Updates the logic in FHIRReceiverFilter.evaluateObservationConditionFilters() to be functionally equivalent but more succinct and more computationally efficient. As per the scope of the ticket I did not address upstream refactoring (ie - how condition filtering works) and nor did I change any of the methods in FHIRBundleHelpers.

No new methods added so no new tests. Existing tests cover changes in this PR:


FHIRBundleHelperTests
--
"test filterObservations"
"test filterMappedObservations"

FhirReceiverFilterTests
---
"test filterMappedObservations"
"fail - mapped condition filter fails"
"fail - bundle of only AOEs do not pass mappedConditionFilter"
"success - jurisfilter, qualfilter, routing filter, proc mode passes, and condition filter passes"
"test the bundle queued for the translate function is filtered to conditions the receiver wants"
"test the bundle queued for the translate function is filtered to mapped conditions the receiver wants"
"test a receiver can receive a report when no condition filters are configured"

FhirReceiverFilterIntegrationTests
---
"should send valid FHIR report filtered by condition filter"
"should not send report fully pruned by condition filter"
"should send valid FHIR report with no condition related filtering"
"should not send report where the only unpruned observations are AOE"
"should send valid FHIR report filtered by mapped condition filter"
"should not send report fully pruned by mapped condition filter"

Testing

  • [x ] Tested locally?
  • [x ] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?

@david-navapbc david-navapbc requested a review from a team as a code owner September 8, 2024 20:45
Copy link
Contributor

github-actions bot commented Sep 8, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

github-actions bot commented Sep 8, 2024

Test Results

1 217 tests  ±0   1 213 ✅ ±0   6m 47s ⏱️ +11s
  158 suites ±0       4 💤 ±0 
  158 files   ±0       0 ❌ ±0 

Results for commit a749e4c. ± Comparison against base commit 1220903.

Copy link

sonarqubecloud bot commented Sep 8, 2024

Copy link
Contributor

github-actions bot commented Sep 8, 2024

Integration Test Results

 53 files  ±0   53 suites  ±0   28m 8s ⏱️ +9s
408 tests ±0  399 ✅ ±0  9 💤 ±0  0 ❌ ±0 
411 runs  ±0  402 ✅ ±0  9 💤 ±0  0 ❌ ±0 

Results for commit a749e4c. ± Comparison against base commit 1220903.

@david-navapbc david-navapbc added the platform Platform Team label Sep 9, 2024
@david-navapbc david-navapbc marked this pull request as draft September 9, 2024 17:02
auto-merge was automatically disabled September 9, 2024 17:02

Pull request was converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform Platform Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants