Refactoring container build to use CDCgov/cfa-actions/twostep-container-build #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution @micahwiesner67 🚀! Your pkgdown-site is ready for download 👉 here 👈! |
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files📢 Thoughts on this report? Let us know! |
|
Hey George -- wanted to note that I've seen this one and I've been holding off on reviewing pending discussion on CDCgov/cfa-actions#13 |
Co-authored-by: Nate McIntosh <[email protected]>
|
@zsusswein I think for now we should approve this. The GHA dependence is a larger discussion, and this action doesn't make us more or less dependent on GHA than we were without having these organized into a cfa-actions GHA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to streamline the build process for Docker images and update the Dockerfile reference. The most important changes include renaming and consolidating jobs in the GitHub Actions workflow, and modifying the Dockerfile to reference the correct base image.
Improvements to GitHub Actions workflow:
.github/workflows/containers-and-az-pool.yaml: Renamedbuild-dependencies-imagejob tobuild-pipeline-imageand removed redundant steps, consolidating the build process into a single job usingtwostep-container-buildaction. [1] [2]Updates to Dockerfile:
Dockerfile: Changed the base image reference tocfaprdbatchcr.azurecr.io/cfa-epinow2-pipeline:${TAG}to ensure the correct image is used.