Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNDIT-1671: Add Kafka listener for Notification changing event #36

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

sveselev
Copy link
Collaborator

@sveselev sveselev commented Sep 12, 2024

Description

Introduces a dedicated Kafka listener for handling Notification changes in the Investigation service; includes enhancements focused on performance and code readability.

  • InvestigationService.java: added the new processNotification method and improved exception handling.
  • NotificationUpdate.java: DTO to handle the sp_notification_event output.
  • 020-sp_notification_event-002.sql: updated version of the procedure containing notification_uid in the ouptput
  • UtilHelper.java: moved to common-util

JIRA

CNDIT-1671

@sveselev sveselev marked this pull request as draft September 12, 2024 23:05
@sveselev sveselev marked this pull request as ready for review September 13, 2024 20:02
Copy link
Collaborator

@upasanapattnaik-eq upasanapattnaik-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the event of a Notification being created at the same time as an investigation- PHC event and Notification event, we will be expecting two events, correct?

Copy link
Collaborator

@upasanapattnaik-eq upasanapattnaik-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@sveselev
Copy link
Collaborator Author

In the event of a Notification being created at the same time as an investigation- PHC event and Notification event, we will be expecting two events, correct?

Correct!

@upasanapattnaik-eq
Copy link
Collaborator

In the event of a Notification being created at the same time as an investigation- PHC event and Notification event, we will be expecting two events, correct?

Correct!

Sounds good. The data is the same at that point of time. Would there be any cases that we would expect differently?

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
77.4% Coverage on New Code (required ≥ 90%)
8 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@sveselev sveselev merged commit 7171ba6 into main Sep 16, 2024
1 of 2 checks passed
@sveselev sveselev deleted the CNDIT-1671-rtr-investigation-add-notification-listener branch September 16, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants