-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNDIT-1671: Add Kafka listener for Notification changing event #36
CNDIT-1671: Add Kafka listener for Notification changing event #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the event of a Notification being created at the same time as an investigation- PHC event and Notification event, we will be expecting two events, correct?
...ervice/src/main/java/gov/cdc/etldatapipeline/investigation/service/InvestigationService.java
Show resolved
Hide resolved
liquibase-service/src/main/resources/db/odse/routines/020-sp_notification_event-002.sql
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 💯
Correct! |
Sounds good. The data is the same at that point of time. Would there be any cases that we would expect differently? |
|
Description
Introduces a dedicated Kafka listener for handling Notification changes in the Investigation service; includes enhancements focused on performance and code readability.
InvestigationService.java
: added the new processNotification method and improved exception handling.NotificationUpdate.java
: DTO to handle thesp_notification_event
output.020-sp_notification_event-002.sql
: updated version of the procedure containingnotification_uid
in the ouptputUtilHelper.java
: moved tocommon-util
JIRA
CNDIT-1671