Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNDE-2070 #131

Merged
merged 5 commits into from
Jan 16, 2025
Merged

CNDE-2070 #131

merged 5 commits into from
Jan 16, 2025

Conversation

upasanapattnaik-eq
Copy link
Collaborator

@upasanapattnaik-eq upasanapattnaik-eq commented Jan 13, 2025

Notes

Upstream Investigation fix for std_hiv_datamart hydration.

  • COALESCE for RPT_SRC_CD_DESC to get code when value is null.
  • Wire in INV_CLOSE_DT in post-processing.
  • Address empty string investigation codes columns with NULLIF.
  • Addition of detection_method_cd to nrt_investigation.

JIRA

Checklist

Types of changes

What types of changes does this PR introduces?

  • Bugfix
  • New feature
  • Breaking change

Testing

  • Does this PR has >90% code coverage?
  • Is the screenshot attached for code coverage?
  • Does the gradle build pass in your local?
  • Is the gradle build logs attached?

Copy link
Collaborator

@sveselev sveselev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@upasanapattnaik-eq upasanapattnaik-eq merged commit 74a3bf1 into main Jan 16, 2025
3 checks passed
@upasanapattnaik-eq upasanapattnaik-eq deleted the CNDE-2070 branch January 23, 2025 22:17
@alog-enquizit alog-enquizit restored the CNDE-2070 branch February 4, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants