Merge remote-tracking branch 'upstream/main' into custom_auth #66
clippy
7 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 0 |
| Warning | 7 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.84.0-nightly (03ee48451 2024-11-18)
- cargo 1.84.0-nightly (69e595908 2024-11-16)
- clippy 0.1.84 (03ee484519 2024-11-18)
Annotations
Check warning on line 43 in azalea-protocol/src/lib.rs
github-actions / clippy
the following explicit lifetimes could be elided: 'a
warning: the following explicit lifetimes could be elided: 'a
--> azalea-protocol/src/lib.rs:43:6
|
43 | impl<'a> TryFrom<&'a str> for ServerAddress {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
43 - impl<'a> TryFrom<&'a str> for ServerAddress {
43 + impl TryFrom<&str> for ServerAddress {
|
Check warning on line 245 in azalea-protocol/src/read.rs
github-actions / clippy
the following explicit lifetimes could be elided: 'a
warning: the following explicit lifetimes could be elided: 'a
--> azalea-protocol/src/read.rs:245:30
|
245 | pub async fn read_raw_packet<'a, R>(
| ^^
246 | stream: &'a mut R,
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
Check warning on line 212 in azalea-protocol/src/read.rs
github-actions / clippy
the following explicit lifetimes could be elided: 'a
warning: the following explicit lifetimes could be elided: 'a
--> azalea-protocol/src/read.rs:212:26
|
212 | pub async fn read_packet<'a, P: ProtocolPacket + Debug, R>(
| ^^
213 | stream: &'a mut R,
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
Check warning on line 158 in azalea-world/src/find_blocks.rs
github-actions / clippy
the following explicit lifetimes could be elided: 'a
warning: the following explicit lifetimes could be elided: 'a
--> azalea-world/src/find_blocks.rs:158:6
|
158 | impl<'a> Iterator for FindBlocks<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
158 - impl<'a> Iterator for FindBlocks<'a> {
158 + impl Iterator for FindBlocks<'_> {
|
Check warning on line 231 in azalea-world/src/bit_storage.rs
github-actions / clippy
the following explicit lifetimes could be elided: 'a
warning: the following explicit lifetimes could be elided: 'a
--> azalea-world/src/bit_storage.rs:231:6
|
231 | impl<'a> Iterator for BitStorageIter<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
231 - impl<'a> Iterator for BitStorageIter<'a> {
231 + impl Iterator for BitStorageIter<'_> {
|
Check warning on line 122 in azalea-world/src/bit_storage.rs
github-actions / clippy
manually reimplementing `div_ceil`
warning: manually reimplementing `div_ceil`
--> azalea-world/src/bit_storage.rs:122:33
|
122 | let calculated_length = (size + values_per_long - 1) / values_per_long;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `size.div_ceil(values_per_long)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil
= note: `#[warn(clippy::manual_div_ceil)]` on by default
Check warning on line 71 in azalea-auth/src/auth.rs
github-actions / clippy
the following explicit lifetimes could be elided: 'a
warning: the following explicit lifetimes could be elided: 'a
--> azalea-auth/src/auth.rs:71:19
|
71 | pub async fn auth<'a>(email: &str, opts: AuthOpts<'a>) -> Result<AuthResult, AuthError> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default