forward to swarm for easier use #10
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
Annotations
10 warnings
you are using an explicit closure for cloning elements:
azalea/src/swarm/mod.rs#L602
warning: you are using an explicit closure for cloning elements
--> azalea/src/swarm/mod.rs:602:25
|
602 | let proxy = self.proxies.choose(&mut thread_rng()).map(|p| p.clone());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.proxies.choose(&mut thread_rng()).cloned()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
= note: `#[warn(clippy::map_clone)]` on by default
|
this `let...else` may be rewritten with the `?` operator:
azalea/src/pathfinder/world.rs#L160
warning: this `let...else` may be rewritten with the `?` operator
--> azalea/src/pathfinder/world.rs:160:9
|
160 | / let Some(chunk) = world.chunks.get(&chunk_pos) else {
161 | | return None;
162 | | };
| |__________^ help: replace it with: `let chunk = world.chunks.get(&chunk_pos)?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
= note: `#[warn(clippy::question_mark)]` on by default
|
the borrowed expression implements the required traits:
azalea-protocol/src/connect.rs#L281
warning: the borrowed expression implements the required traits
--> azalea-protocol/src/connect.rs:281:80
|
281 | Some((username, password)) => Some(UserKey::new(&username, &password)),
| ^^^^^^^^^ help: change this to: `password`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
the borrowed expression implements the required traits:
azalea-protocol/src/connect.rs#L281
warning: the borrowed expression implements the required traits
--> azalea-protocol/src/connect.rs:281:69
|
281 | Some((username, password)) => Some(UserKey::new(&username, &password)),
| ^^^^^^^^^ help: change this to: `username`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
manual implementation of `Option::map`:
azalea-protocol/src/connect.rs#L280
warning: manual implementation of `Option::map`
--> azalea-protocol/src/connect.rs:280:28
|
280 | let auth = match proxy.auth {
| ____________________________^
281 | | Some((username, password)) => Some(UserKey::new(&username, &password)),
282 | | None => None,
283 | | };
| |_________________^ help: try: `proxy.auth.map(|(username, password)| UserKey::new(&username, &password))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
= note: `#[warn(clippy::manual_map)]` on by default
|
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|