refactor: Gson creation #5587
Merged
refactor: Gson creation #5587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqlerrorthing
approved these changes
Feb 12, 2025
| @@ -108,7 +108,7 @@ val publicGson: Gson = GsonBuilder() | |||
| /** | |||
| * This GSON instance is used for interop communication. | |||
| */ | |||
| internal val interopGson = GsonBuilder() | |||
| internal val interopGson: Gson = GsonBuilder() | |||
There was a problem hiding this comment.
does this making sense?
There was a problem hiding this comment.
Because other instances have that
| @@ -118,7 +118,7 @@ internal val interopGson = GsonBuilder() | |||
| * This GSON instance is used for serializing objects as accessible JSON which means it is READ-ONLY (!) | |||
| * and often comes with an easier syntax to use in other programming languages like JavaScript. | |||
| */ | |||
| internal val accessibleInteropGson = GsonBuilder() | |||
| internal val accessibleInteropGson: Gson = GsonBuilder() | |||
There was a problem hiding this comment.
does this making sense?
| @@ -68,7 +66,7 @@ object ModuleDebugRecorder : ClientModule("DebugRecorder", Category.MISC) { | |||
| file = folder.resolve("${baseName}_${idx++}.json") | |||
| } | |||
|
|
|||
| Files.write(file.toPath(), Gson().toJson(this.packets).toByteArray(Charset.forName("UTF-8"))) | |||
| file.writeText(publicGson.toJson(this.packets)) | |||
Comment on lines
+14
to
+16
| ModuleMurderMystery.javaClass.getResourceAsStream("/resources/liquidbounce/data/$FILE_NAME") | ||
|
|
||
| check(stream != null) { "Unable to find hypixel_mm_letters.json!" } | ||
| checkNotNull(stream) { "Unable to find $FILE_NAME!" } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.