Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS blur issue #5586

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Fix macOS blur issue #5586

merged 2 commits into from
Feb 24, 2025

Conversation

heckerpowered
Copy link
Contributor

As the comment says,

Only blur on Windows and Linux - Mac seems to have issues with it

I don't know what the principle is, but is solved anyway.

Tested on macOS 15.3

@1zun4
Copy link
Member

1zun4 commented Feb 12, 2025

You may also want to remove the MacOS check if your patch fixes it.

@1zun4 1zun4 added this to the 0.27.0 milestone Feb 12, 2025
Copy link
Contributor

@superblaubeere27 superblaubeere27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the issue reappear if you remove the layout (location = 0/1) declaration?

@1zun4 1zun4 merged commit f6919d2 into CCBlueX:nextgen Feb 24, 2025
3 checks passed
@heckerpowered
Copy link
Contributor Author

heckerpowered commented Feb 25, 2025

Does the issue reappear if you remove the layout (location = 0/1) declaration?

yes (this solution absolutely works on my machine)

And I found out that most shaders need layout declarations to work normally, but it isn’t needed on Windows. Maybe it’s because macOS doesn’t support OpenGL directly, but a bug caused by Metal simulation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants