Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: NPE with CrystalAura #5544

Merged
merged 4 commits into from
Feb 7, 2025
Merged

fix: NPE with CrystalAura #5544

merged 4 commits into from
Feb 7, 2025

Conversation

MukjepScarlet
Copy link
Contributor

fixes #5543

@MukjepScarlet
Copy link
Contributor Author

I didn't check this in other modules actually.

@1zun4 1zun4 requested review from 1zun4 and removed request for superblaubeere27 February 7, 2025 05:13
1zun4
1zun4 approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@1zun4 1zun4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a little to figure out what changed - but I think I got the idea. I would have probably done this differently but this solution should be alright as well.

And looks like it passes the RequestHandlerTest.

@1zun4 1zun4 merged commit 1101f50 into CCBlueX:nextgen Feb 7, 2025
3 checks passed
@MukjepScarlet MukjepScarlet deleted the fix/ca branch February 7, 2025 05:15
1zun4 pushed a commit to DataM0del/LiquidBounce that referenced this pull request Feb 8, 2025
@MukjepScarlet @1zun4
fix: NPE with CrystalAura (CCBlueX#5544)
3848c4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1zun4 1zun4 1zun4 approved these changes

@sqlerrorthing sqlerrorthing sqlerrorthing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Random NPEs while CrystalAura is enabled
3 participants
@MukjepScarlet @1zun4 @sqlerrorthing