Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CPS for Keystrokes (HUD) #4192

Open
wants to merge 2 commits into
base: nextgen
Choose a base branch
from

Conversation

MukjepScarlet
Copy link
Contributor

image

It can record mouse button and keyboard clicks.

Width may need adjustment, English text is too long.

@liquidsquid1
Copy link
Contributor

Nobody needs to know the cps of the space key, they normally only care about the mouse buttons. Also, you can use the abbreviation “LMB” and “RMB” as people will understand what that means from other clients.

@MukjepScarlet
Copy link
Contributor Author

Now the client uses localized name of keys and mouse buttons. LMB and RMB may be confusing if the players don't play game in English, or they just don't bind attack and use to LMB and RMB (Although this is rare).

@liquidsquid1
Copy link
Contributor

maybe you can make some sort of input translator as a typescript file where it changes keybinds to known abbreviations (like Left Button will Return LMB) so that other binds are proper.

@MukjepScarlet
Copy link
Contributor Author

I'd like to use icons for them. It's better than abbreviations I think.

@MukjepScarlet
Copy link
Contributor Author

image

It will be something like this. But I don't know how to draw SVG, so this may require the help of others.

@1zun4
Copy link
Member

1zun4 commented Oct 25, 2024

just write the digit, no icon, no cps:

@MukjepScarlet
Copy link
Contributor Author

Left Button
     4

Like this? the "Right Button" will still wrap lines.

@1zun4
Copy link
Member

1zun4 commented Oct 25, 2024

Left Button
     4

Like this? the "Right Button" will still wrap lines.

no just put the number, no one needs to know if its right or left button

@MukjepScarlet
Copy link
Contributor Author

OK

@liquidsquid1
Copy link
Contributor

i think the idea of the arrows on the top buttons would be nice, means there is less text on the screen

@1zun4
Copy link
Member

1zun4 commented Oct 26, 2024

i think the idea of the arrows on the top buttons would be nice, means there is less text on the screen

the arrows look super weird

@MukjepScarlet
Copy link
Contributor Author

This could be merged, I still uses localized names for keys, and only CPS value for mouse buttons.
@1zun4

@MukjepScarlet
Copy link
Contributor Author

If we use icons instead, this (#3897) can be solved too.

@1zun4 1zun4 requested a review from SenkJu November 1, 2024 10:29
@1zun4
Copy link
Member

1zun4 commented Nov 5, 2024

PR on hold and waiting for completion of #3884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants