-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CPS for Keystrokes (HUD) #4192
base: nextgen
Are you sure you want to change the base?
Conversation
Nobody needs to know the cps of the space key, they normally only care about the mouse buttons. Also, you can use the abbreviation “LMB” and “RMB” as people will understand what that means from other clients. |
Now the client uses localized name of keys and mouse buttons. LMB and RMB may be confusing if the players don't play game in English, or they just don't bind |
maybe you can make some sort of input translator as a typescript file where it changes keybinds to known abbreviations (like Left Button will Return LMB) so that other binds are proper. |
07c4fb2
to
a387409
Compare
I'd like to use icons for them. It's better than abbreviations I think. |
just write the digit, no icon, no cps: |
Like this? the "Right Button" will still wrap lines. |
no just put the number, no one needs to know if its right or left button |
OK |
i think the idea of the arrows on the top buttons would be nice, means there is less text on the screen |
ab13fc5
to
162df5b
Compare
the arrows look super weird |
This could be merged, I still uses localized names for keys, and only CPS value for mouse buttons. |
If we use icons instead, this (#3897) can be solved too. |
PR on hold and waiting for completion of #3884 |
It can record mouse button and keyboard clicks.
Width may need adjustment, English text is too long.