Leaves many #273
Merged
Leaves many #273
+62
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if everyone likes this overloading of this method or would prefer that it is broken out in a seperate method |
this was going to be my comment, I think avoiding variable types on the output is helpful so I lean separate method, personally |
|
that was sven's instinct too.. i have moved it to a seperate method. |
bdpedigo
approved these changes
Dec 4, 2024
kebwi
pushed a commit
that referenced
this pull request
Dec 9, 2024
* adding leaves many * add test * fix test * fix test again * move to seperate method * cleaning up doc string * fixing dictionary return * fix formatting * fixing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds the ability to use leaves_many from a list of root_ids to the get_leaves function.