Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broaden array-like types allowed for root IDs #183

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Broaden array-like types allowed for root IDs #183

merged 1 commit into from
Apr 26, 2024

Conversation

bdpedigo
Copy link
Collaborator

No description provided.

@ceesem
Copy link
Collaborator

ceesem commented Apr 19, 2024 •
edited
Loading

Seems like perhaps a more generic fix would be helpful. We could
have a ListLike tuple in caveclient.base that can be repurposed whenever we need to check isinstance in cases like this?

@fcollman
Copy link
Collaborator

Seems like perhaps a more generic fix would be helpful. We could have a ListLike tuple in caveclient.base that can be repurposed whenever we need to check isinstance in cases like this?

I agree with this but this does seem strictly better so i'm going to merge it until we have the more generic option

@fcollman fcollman merged commit 75ab93c into master Apr 26, 2024
16 checks passed
@bdpedigo bdpedigo deleted the broaden-types branch April 26, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdpedigo @ceesem @fcollman