Add ruff code formatting and linting github action #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ceesem this is another option https://pre-commit.com/ |
bdpedigo
commented
Mar 22, 2024
| and v is not None | ||
| and a.metadata.get("is_bbox", False) == False | ||
| and a.metadata.get("is_meta", False) == False | ||
| and a.metadata.get("is_bbox", False) == False # noqa E712 |
There was a problem hiding this comment.
could just fix these... but unsure whether this get could return a string, and then things get weird... so i opted to just tell it to shut up for these, and hopefully in the future we can just follow the linting
bdpedigo
commented
Mar 22, 2024
| @@ -78,10 +79,9 @@ def get_all_view_metadata(client): | |||
| def is_list_like(x): | |||
| if isinstance(x, str): | |||
| return False | |||
| try: | |||
| len(x) | |||
| if hasattr(x, "__len__"): | |||
There was a problem hiding this comment.
this should be the same functionality but happy to change it back and noqa it if anyone is concerned
bdpedigo
commented
Mar 22, 2024
| @@ -18,7 +20,7 @@ class TestInfoClient: | |||
|
|
|||
| @responses.activate | |||
| def test_infoclient(self, myclient, mocker): | |||
| endpoint_mapping = self.default_mapping | |||
| endpoint_mapping = self.default_mapping # noqa F841 | |||
There was a problem hiding this comment.
@ceesem this is giving F841 Local variable endpoint_mapping is assigned to but never used but i opted to leave it because of what we just discussed w pytest. lmk if you think this is really not used, though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #169
this adds a formatting enforcement test to the build on pull or push to master