Multischema endpoint #158
Merged
Multischema endpoint #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If some caution is needed perhaps it’s time we added some tests for this |
|
Agreed, will add tests before this gets merged. Although what I was concerned about should be caught by the materialization client tests, if I understand them correctly. |
|
Tests added for the table manager. Not perfect because they have to mock the metadata one gets from the server, but at least there's an example there to compare against. |
fcollman
reviewed
Mar 12, 2024
tests/test_tablemanager.py
Outdated
| assert 'allen_column_mtypes_v2' == qry.joins_kwargs.get('joins')[0][0] | ||
|
|
||
| def test_view_manager(): | ||
| views = ViewManager(None, view_metadata=views_list, view_schema=views_schema) |
There was a problem hiding this comment.
this should be done with responses so it tests that portion of the code
fcollman
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the multischema download endpoints and using them in the tables/views interface. Wound up refactoring the materialization initialization to use multithreading for pinging the server for various information, but on the plus side the .tables and .views interfaces are populated at the same time with minor overhead cost. Also, added small tweaks that seem to improve tab-autocompletion for these services as well.
I think this is working, but there are some changes to client.materialize that could be significant if they don't work as expected, so a bit of caution is warranted.